Enhance send_file function with improved type hinting and error handling #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
MatthewCane
commented
Aug 7, 2025
MatthewCane
commented
- Updated the file parameter to accept both string and Path types.
- Added error handling for file reading failures, raising MessageSendError on exceptions.
- Modified the filename extraction to use Path for better compatibility.
- Introduced a new test case to verify behavior when the specified file is not found.
- Updated the file parameter to accept both string and Path types. - Added error handling for file reading failures, raising MessageSendError on exceptions. - Modified the filename extraction to use Path for better compatibility. - Introduced a new test case to verify behavior when the specified file is not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.