Conversation
MaximilianToe
force-pushed
the
fix_sample_to_umessage
branch
from
65fbf99 to
78cef79
Compare
lammjo
reviewed
Apr 24, 2025
src/ZenohUTransport.cpp
Outdated
| } | ||
|
|
||
| } // namespace uprotocol::transport | ||
| } // namespace uprotocol::transport No newline at end of file |
There was a problem hiding this comment.
Interesting that clang-tidy did not catch this. Did you run clang-format before committing?
src/ZenohUTransport.cpp
Outdated
| options.attachment = zenoh::ext::serialize(attachment); | ||
| session_.put(zenoh::KeyExpr(zenoh_key), zenoh::ext::serialize(payload), | ||
|
|
||
| std::vector<uint8_t> const payload_as_bytes(payload.begin(), |
There was a problem hiding this comment.
For consistency:
Suggested change
| std::vector<uint8_t> const payload_as_bytes(payload.begin(), | |
| const std::vector<uint8_t> payload_as_bytes(payload.begin(), |
| v1::UStatus ZenohUTransport::sendPublishNotification_( | ||
| const std::string& zenoh_key, const std::string& payload, | ||
| const v1::UAttributes& attributes) { | ||
| spdlog::debug("sendPublishNotification_: {}: {}", zenoh_key, payload); |
There was a problem hiding this comment.
It seems that prepending the function name to log messages is the way to go in this codebase, so I suggest sticking to this convention also for the other messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.