Skip to content

Fix Zoho CRM node type errors and update to modern @inngest/realtime API - #54

Closed
kunalBainsla007 with Claude wants to merge 2 commits into
mainfrom
claude/fix-login-issue
Closed

Fix Zoho CRM node type errors and update to modern @inngest/realtime API#54
kunalBainsla007 with Claude wants to merge 2 commits into
mainfrom
claude/fix-login-issue

Conversation

@Claude

@Claude Claude AI commented Mar 17, 2026

Copy link
Copy Markdown

The Zoho CRM node had TypeScript compilation errors due to type mismatches between getSubscriptionToken() expectations (channel name string) and what was being passed (channel object). Additionally, the executor was using deprecated .topic().data() API instead of the modern .status() API.

Changes

Channel Definition (channels.ts)

  • Added zohoCrmChannelName(nodeId) helper function to return channel name string
  • Changed zohoCrmChannel from parameterized function to static Definition using channel(() => ZOHO_CRM_CHANNEL)

Token Subscription (actions.ts, router.ts)

  • Updated getSubscriptionToken calls to use zohoCrmChannelName(nodeId) for channel parameter
  • Removed explicit return type from fetchZohoCrmRealtimeToken to avoid type inference conflicts

Executor (executor.ts)

  • Migrated from deprecated .topic("status").data({...}) to modern .status({...}) API
  • Changed zohoCrmChannel(nodeId) to zohoCrmChannel() to match Definition pattern

Example

Before:

await publish(zohoCrmChannel(nodeId).topic("status").data({ status: "loading", nodeId }))

After:

await publish(zohoCrmChannel().status({ status: "loading", nodeId }))

This aligns Zoho CRM with other nodes (msg91, loop, wait) that use the same pattern.

@coderabbitai

coderabbitai Bot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Free

Run ID: a517ab69-3540-4a8e-98b2-0b759e93f957

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: kunalBainsla007 <204899459+kunalBainsla007@users.noreply.github.com>
@Claude Claude AI changed the title [WIP] Fix the login issue on the main page Fix Zoho CRM type errors by separating channel name from channel definition Mar 17, 2026
@Claude Claude AI changed the title Fix Zoho CRM type errors by separating channel name from channel definition Fix Zoho CRM type error: channel name vs channel object mismatch Mar 17, 2026
@Claude Claude AI changed the title Fix Zoho CRM type error: channel name vs channel object mismatch Fix Zoho CRM node type errors and update to modern @inngest/realtime API Mar 17, 2026
Copilot stopped work on behalf of kunalBainsla007 due to an error March 17, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants