Fix Zoho CRM node type errors and update to modern @inngest/realtime API - #54
Closed
kunalBainsla007 with Claude wants to merge 2 commits into
Closed
Fix Zoho CRM node type errors and update to modern @inngest/realtime API#54kunalBainsla007 with Claude wants to merge 2 commits into
kunalBainsla007 with Claude wants to merge 2 commits into
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 Coding Plan
Comment |
Co-authored-by: kunalBainsla007 <204899459+kunalBainsla007@users.noreply.github.com>
Copilot stopped work on behalf of
kunalBainsla007 due to an error
March 17, 2026 17:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Zoho CRM node had TypeScript compilation errors due to type mismatches between
getSubscriptionToken()expectations (channel name string) and what was being passed (channel object). Additionally, the executor was using deprecated.topic().data()API instead of the modern.status()API.Changes
Channel Definition (
channels.ts)zohoCrmChannelName(nodeId)helper function to return channel name stringzohoCrmChannelfrom parameterized function to static Definition usingchannel(() => ZOHO_CRM_CHANNEL)Token Subscription (
actions.ts,router.ts)getSubscriptionTokencalls to usezohoCrmChannelName(nodeId)for channel parameterfetchZohoCrmRealtimeTokento avoid type inference conflictsExecutor (
executor.ts).topic("status").data({...})to modern.status({...})APIzohoCrmChannel(nodeId)tozohoCrmChannel()to match Definition patternExample
Before:
After:
This aligns Zoho CRM with other nodes (msg91, loop, wait) that use the same pattern.