Skip to content

Added github link in footer (#345)#347

Merged
gr812b merged 2 commits intoMcMaster-Baja-Racing:mainfrom
garvitdayal28:issue-345
Jan 21, 2026
Merged

Added github link in footer (#345)#347
gr812b merged 2 commits intoMcMaster-Baja-Racing:mainfrom
garvitdayal28:issue-345

Conversation

@garvitdayal28
Copy link
Contributor

@garvitdayal28 garvitdayal28 commented Jan 15, 2026

I've added the github link in the footer as mentioned in the issue. Please review the PR and check if there is a improvement needed
Screenshot From 2026-01-15 14-22-31

Screenshot From 2026-01-15 14-25-45

Copy link
Collaborator

@gr812b gr812b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me, if you could include an image in the PR that would be great. If not I'll run it tonight and approve

@gr812b gr812b linked an issue Jan 15, 2026 that may be closed by this pull request
@gr812b
Copy link
Collaborator

gr812b commented Jan 15, 2026

Looks right to me, if you could include an image in the PR that would be great. If not I'll run it tonight and approve

Oops lol @garvitdayal28 I meant a pic of the front end / how it looks rather than the code

@garvitdayal28
Copy link
Contributor Author

garvitdayal28 commented Jan 16, 2026

image
Screencast.From.2026-01-16.17-23-07.mp4

@gr812b
Copy link
Collaborator

gr812b commented Jan 16, 2026

@garvitdayal28 if you'd swap to this svg everything else looks great!

github

@garvitdayal28
Copy link
Contributor Author

Changed the icon

Screenshot From 2026-01-17 13-29-58

Copy link
Collaborator

@gr812b gr812b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gr812b
Copy link
Collaborator

gr812b commented Jan 20, 2026

@garvitdayal28 I think this is the first time we've had someone not in the org suggest changes, normally I let the pull requester merge their own changes but I figured you might not be able to. Just wondering if you can or can't, if not I'll merge it in

@garvitdayal28
Copy link
Contributor Author

@garvitdayal28 I think this is the first time we've had someone not in the org suggest changes, normally I let the pull requester merge their own changes but I figured you might not be able to. Just wondering if you can or can't, if not I'll merge it in

Yeah, you should do it

@gr812b gr812b merged commit 97e0716 into McMaster-Baja-Racing:main Jan 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Github to Links in bottom bar

2 participants