Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 8, 2025

๋ฆด๋ฆฌ์ฆˆ ๋…ธํŠธ

์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ

๋ฒ„๊ทธ ์ˆ˜์ •

๊ธฐํƒ€ ๋ณ€๊ฒฝ์‚ฌํ•ญ

rappire and others added 21 commits May 9, 2025 22:10
* fix: ๐Ÿ› correct CORS exposed headers formatting in SecurityConfig

* fix: ๐Ÿ› update Tus extension header value in TusController

* fix: ๐Ÿ› update Tus file location handling to use configurable path prefix

* fix: ๐Ÿ› change uploadLength type to Integer and improve metadata parsing error handling

* fix: ๐Ÿ› update mergePath configuration and adjust file merging logic in TusService
* Revert "fix: ๐Ÿ› declare entitymanger.flush (#250)"

This reverts commit dfe1afb.

* Revert "refactor: โ™ป๏ธ refactor fileid to counselsession id (#249)"

This reverts commit fb28df3

* Revert "fix: ๐Ÿ”Š add log for tusService (#248)"

This reverts commit 20d7610.

* Revert "refactor: ๐Ÿ› delete files when error happend on merging (#246)"

This reverts commit 4efaed9.
- NoContentException ํด๋ž˜์Šค์— ์ŠคํƒํŠธ๋ ˆ์ด์Šค๋ฅผ ์ƒ์„ฑํ•˜์ง€ ์•Š๋„๋ก ์ˆ˜์ •ํ•˜์—ฌ ์„ฑ๋Šฅ ์ตœ์ ํ™”
- AI ์‘๋‹ต ํŒŒ์‹ฑ์„ ์œ„ํ•œ AiResponseParseUtil ํด๋ž˜์Šค ์ถ”๊ฐ€, JSON ๊ตฌ์กฐ์—์„œ ์•ˆ์ „ํ•˜๊ฒŒ ๋ฐ์ดํ„ฐ ์ถ”์ถœ ๊ธฐ๋Šฅ ๊ตฌํ˜„
- AICounselSummaryService์—์„œ AI ์‘๋‹ต ํŒŒ์‹ฑ ์œ ํ‹ธ๋ฆฌํ‹ฐ ์‚ฌ์šฉํ•˜์—ฌ ์ฝ”๋“œ ๊ฐ„์†Œํ™”
- ๋‚ด ์ •๋ณด ์—…๋ฐ์ดํŠธ API ๋ฐ DTO ์ถ”๊ฐ€
- ๋น„๋ฐ€๋ฒˆํ˜ธ ๋ณ€๊ฒฝ API ๋ฐ DTO ์ถ”๊ฐ€
- ๊ณ„์ • ํƒˆํ‡ด API ๊ตฌํ˜„
- ๊ด€๋ จ ์„œ๋น„์Šค ๋กœ์ง ์ถ”๊ฐ€ ๋ฐ ์˜ˆ์™ธ ์ฒ˜๋ฆฌ ๊ฐœ์„ 
@github-actions github-actions bot added the D-3 label Jun 8, 2025
cursor[bot]

This comment was marked as outdated.

@github-actions
Copy link
Contributor Author

github-actions bot commented Jun 8, 2025

Test Results

72 testsโ€‚โ€ƒโ€ƒ63 โœ…โ€ƒโ€ƒ2s โฑ๏ธ
14 suitesโ€ƒโ€ƒโ€‡9 ๐Ÿ’ค
14 filesโ€„โ€‚โ€ƒโ€ƒโ€‡0 โŒ

Results for commit 2be2105.

โ™ป๏ธ This comment has been updated with latest results.

- ์ƒ๋‹ด์‚ฌ ์ •๋ณด ์—…๋ฐ์ดํŠธ ์‹œ ์ด๋ฆ„๊ณผ ์ „ํ™”๋ฒˆํ˜ธ๋ฅผ ์ง์ ‘ ์„ค์ •ํ•˜๋„๋ก ๋ณ€๊ฒฝ
- Keycloak ์‚ฌ์šฉ์ž ์‚ญ์ œ ๋กœ์ง์—์„œ ์‚ฌ์šฉ์ž๋ช… ํ™•์ธ ์ ˆ์ฐจ ๊ฐ„์†Œํ™”
- ๋ถˆํ•„์š”ํ•œ ์˜ˆ์™ธ ์ฒ˜๋ฆฌ ์ฝ”๋“œ ์ œ๊ฑฐ
cursor[bot]

This comment was marked as outdated.

@github-actions github-actions bot added D-2 and removed D-3 D-2 labels Jun 8, 2025
@github-actions github-actions bot added D-1 D-0 urgent and removed D-1 labels Jun 9, 2025
@jawsbaek jawsbaek closed this Jun 16, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Active Sessions Automatically Canceled After 24 Hours

Overdue session cancellation logic now includes IN_PROGRESS sessions, causing active counseling sessions to be automatically canceled if they run 24 hours past their scheduled start time. This can disrupt ongoing consultations and lead to data loss.

src/main/java/com/springboot/api/counselsession/repository/CounselSessionRepositoryImpl.java#L143-L144

.where(
counselSession.status.in(ScheduleStatus.SCHEDULED, ScheduleStatus.IN_PROGRESS),

Fix in Cursor


Bug: API Change: `sessionNumber` Type Modified

The sessionNumber field in SelectCounselSessionRes was changed from Integer to String. This is a breaking API change as it alters the expected data type for consumers and now returns "-" for canceled sessions instead of a numeric value.

src/main/java/com/springboot/api/counselsession/dto/counselsession/SelectCounselSessionRes.java#L17-L37

private String counselorName;
private String sessionNumber;
private ScheduleStatus status;
public static SelectCounselSessionRes from(CounselSession counselSession) {
SelectCounselSessionRes res = new SelectCounselSessionRes();
res.counselSessionId = counselSession.getId();
res.scheduledTime = counselSession.getScheduledStartDateTime().toLocalTime().toString();
res.scheduledDate = counselSession.getScheduledStartDateTime().toLocalDate().toString();
res.counseleeId = counselSession.getCounselee().getId();
res.counseleeName = counselSession.getCounselee().getName();
Counselor counselor = counselSession.getCounselor();
res.counselorId = (counselor != null) ? counselor.getId() : "";
res.counselorName = (counselor != null) ? counselor.getName() : "";
res.status = counselSession.getStatus();
res.sessionNumber = res.status == ScheduleStatus.CANCELED ? "-" :
String.valueOf(counselSession.getSessionNumber());

Fix in Cursor


Bug: Null Counselor Causes Expression Failures

A NullPointerException occurs in the CaseBuilder expressions for counselor ID and name when counselSession.counselor is null, due to accessing counselSession.counselor.status without a prior null check.

src/main/java/com/springboot/api/counselsession/repository/CounselSessionRepositoryImpl.java#L87-L96

counselSession.counselee.name,
new CaseBuilder()
.when(counselSession.counselor.status.eq(CounselorStatus.INACTIVE))
.then("")
.otherwise(counselSession.counselor.id),
new CaseBuilder()
.when(counselSession.counselor.status.eq(CounselorStatus.INACTIVE))
.then("ํƒˆํ‡ด์‚ฌ์šฉ์ž")
.otherwise(counselSession.counselor.name),
counselSession.status,

Fix in Cursor


Was this report helpful? Give feedback by reacting with ๐Ÿ‘ or ๐Ÿ‘Ž

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

D-0 urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants