Sync production changes back to git #15
Conversation
|
As I've said on irc, I think this is good as a branch to document current state, but not for merging into master. I'll leave a couple of more specific comments for the person who is going to selectively take the good bits. |
larstiq
left a comment
larstiq
left a comment
There was a problem hiding this comment.
Some hints for a cherrypicker.
| @@ -0,0 +1,22 @@ | |||
| [program:defineimage] | |||
There was a problem hiding this comment.
This and the other two participants should not go in. defineimage and do_build_trial got removed in git history. wait_for_repo_published is unused (perhaps it shares ancestry with is_repo_published?)
| with open(os.path.join(bugzilla["template_store"], wid.params.template)) as fileobj: | ||
| comment = prepare_comment(fileobj.read(), wid.fields.as_dict(), extra_data) | ||
| elif wid.fields.reports and wid.fields.reports.bz_comment_template: | ||
| with open(os.path.join(bugzilla["template_store"], wid.fields.reports.bz_comment_template)) as fileobj: |
There was a problem hiding this comment.
This is probably fine, where did it open(wid.params.template) before?
| matches = set([(match.group(), match.group('key')) for match in bugzilla['compiled_re'].finditer(entry)]) | ||
| for remote_re in bugzilla['remote_tags_re']: | ||
| for match in remote_re.finditer(entry): | ||
| print match.group() |
There was a problem hiding this comment.
Debugging, don't necessarily need it.
| if "revert" in wid.fields.ev.description.lower(): | ||
| wid.result = True | ||
| return | ||
|
|
| "%s" % (package, | ||
| bugzilla['regexp'])) | ||
| "%s or %s" % (package, | ||
| bugzilla['regexp'], bugzilla['remote_tags'])) |
| ReportUploader, get_results_files_list, move_results_dir | ||
| ) | ||
|
|
||
| from qarep.upload import * |
There was a problem hiding this comment.
Hmm, I consider the qareports in dister code to be authorative. More checking required.
| allow_recursive(bool) TODO: NOT YET IMPLEMENTED! | ||
| shall the patterns expanding be recursive: True recusive, False do not | ||
| allow_recursive(bool): | ||
| shall the patterns expanding be recursive: True recusive, False do not |
There was a problem hiding this comment.
Do we still use this? Non functional changes anyway.
|
|
||
| submits = [act['targetpackage'] for act in actions if act['type'] == 'submit'] | ||
| # Copy packages into trial area | ||
| for act in actions: |
There was a problem hiding this comment.
I trust this file to be basically correct, though doesn't hurt to check.
| uploaded, errors = self.__update_meta(project, prjconf, "prjconf") | ||
| if uploaded: | ||
| wid.fields.msg.extend(["Updated %s in %s" % (upload, project) \ | ||
| for upload in uploaded]) |
There was a problem hiding this comment.
Same as for setup_build_trial.py
| if errors: | ||
| return uploaded, errors | ||
| # Extract pattern (xml) files from the rpm | ||
| print lab.real_path(binary) |
Changes from production systems