added filtering ability. #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -393,22 +396,30 @@ def get_start_date(self, state, catalog_entry): | |||
| def _build_query_string(self, catalog_entry, start_date, end_date=None, order_by_clause=True): | |||
| selected_properties = self._get_selected_properties(catalog_entry) | |||
|
|
|||
| query = "SELECT {} FROM {}".format(",".join(selected_properties), catalog_entry["stream"]) | |||
| query = "SELECT {} FROM {}".format(",".join(selected_properties), catalog_entry['stream']) | |||
There was a problem hiding this comment.
Hey @jrsperry. Can we revert these styling changes? If just to make reviewing the actual changes easier.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to supply filters. Very handy to avoid having to pull all records (say for example isDeleted, or by some ownerId etc.).
Current implementation would only work if you are pulling a single object, or apply it to all objects being pulled. More than happy to adjust it to be smarter than that.
I can write tests, but i don't see any tests in the project.