fix(bounties,sponsors): add discovery filters on GET /bounties, protect sponsors routes with JwtAuthGuard, and add test coverage (#144, #137, #141, #136) - #187
Open
ghzhost wants to merge 1 commit into
Conversation
…ct sponsors routes with JwtAuthGuard, and add test coverage (MergeFi#144, MergeFi#137, MergeFi#141, MergeFi#136)
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses multiple issues across bounties discovery, sponsors authentication, test coverage, and e2e test titles:
Bounties Filtering (BountiesController.list only supports filtering by status, despite the API tracking difficulty, asset, and repository/language data #144):
ListBountiesQueryDtowithstatus,difficulty,asset,language, andrepositoryIdquery filters.BountiesController.listandBountiesService.listto accept query filters and build dynamic queries joiningissueandrepositorywhenlanguageorrepositoryIdis supplied.Sponsors Auth Guard (SponsorsController has zero authentication guards, exposing a sponsor's full financial dashboard to any unauthenticated caller #137):
@UseGuards(JwtAuthGuard)and@ApiBearerAuth()toGET /sponsors/:id/dashboardandGET /sponsors/:id/milestones/progressto prevent unauthorized access to financial dashboards.Sponsors Service Spec Tests (sponsors.service.spec.ts has no test for activeBounties(), activeMilestones(), or milestoneProgress() #141):
activeBounties(verifying exclusion of terminal statusespaid,refunded,expired).activeMilestones(verifyingFUNDEDandIN_PROGRESSquery matching).milestoneProgress(verifying progress calculation and division-by-zero protection).Users E2E Test Suite (users.e2e-spec.ts's two "should reject unauthenticated requests with 401" tests both actually assert .expect(403) #136):
Validation
npm run buildcompleted with zero TypeScript errors.npm test -- src/sponsors/ src/bounties/passed all 26 unit tests.npm run test:e2epassedtest/users.e2e-spec.ts.Closes #144, Closes #137, Closes #141, Closes #136.