fix(bounties): throw BadRequestException when releasing team bounty with empty splits - #189
Open
moxiaoshen567 wants to merge 1 commit into
Open
Conversation
|
@moxiaoshen567 is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
💰 Payout Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102
Summary
BountiesService.markMergedAndRelease, throwBadRequestExceptionwhen an assigned team has zero member splits (!team || !team.splits || team.splits.length === 0) instead of silently skippingsplitReleaseand erroneously transitioning the bounty status toPAID.src/bounties/bounties.service.spec.tsasserting:markMergedAndReleasethrowsBadRequestExceptionand prevents escrow release / transition toPAIDwhenteam.splitsis empty.markMergedAndReleaseperforms split release as expected when valid splits exist.Verification
/claim #102
💰 Payout Details
6UvBhyhY6ayeoJEGZxK4bDoFAHd9yeRDTVusnoDGdgQ5TYcNrMSoY36q8WrsFSZyB26Rkj25EFgQsX