fix: stop .dockerignore excluding nest-cli.json/tsconfig files needed by builder stage - #238
Merged
chonilius merged 1 commit intoAug 27, 2026
Conversation
… by builder stage Closes MergeFi#176 Closes MergeFi#175 Closes MergeFi#177 Closes MergeFi#8
|
@christianahtemitope2005 is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@christianahtemitope2005 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.dockerignoreexcludednest-cli.json,tsconfig.json, andtsconfig.build.jsonunder the assumption they're only needed at dev time. But the Dockerfile'sbuilderstage doesCOPY . .thennpm run build(nest build), which requires all three files to be present in the build context — excluding them broke the production image build. Removed them from.dockerignore; they're still absent from the finalrunnerstage since onlydist/is copied out ofbuilder.Closes #176
Closes #175
Closes #177
Closes #8