fix: keep top-level dashboard nav highlighted on nested routes (#220) - #302
Closed
tdlxgpp wants to merge 1 commit into
Closed
fix: keep top-level dashboard nav highlighted on nested routes (#220)#302tdlxgpp wants to merge 1 commit into
tdlxgpp wants to merge 1 commit into
Conversation
|
@tdlxgpp is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi @chonilius, I opened this PR for #220. The Vercel deployment check is waiting for a member of the Vercel team to authorize it. Could you authorize it when you have a moment? Happy to make any changes after review. |
Author
|
恭喜 @miraclesonly,PR #323 已合并并完成 #220。我这边较早提交的 PR #302 现在让位关闭,不占用维护者 review 资源。祝项目顺利! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #220
Changes
isNavItemActive(pathname, href)inDashboardShell.tsx./dashboard/*) keep exact matching./issues,/milestones) stay highlighted on nested child routes such as/issues/abc123.Verification
npm test -- --runInBand: 12 suites / 105 tests passed.npm run lint: passed.NEXT_PUBLIC_API_URL=http://localhost:4000/api NEXT_PUBLIC_STELLAR_NETWORK=TESTNET npm run build: passed.AI Usage