Skip to content

Upgrade to Gradle 7.x and NDK r23b #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: oxce-plus-proto
Choose a base branch
from

Conversation

feiyunw
Copy link

@feiyunw feiyunw commented Nov 19, 2021

Upgrade to Android Gradle Plugin 7.0.3, Gradle 7.3, Android SDK Build Tools 30.0.2, set ndkVersion to 23.1.7779620 (r23b) and Java compatibility to VERSION_1_8.

The additions in app/build.gradle were done by Android Studio "File->Project Structure" dialog.

I built an APK release with android-studio-2020.3.1.25-windows on Windows 10. It was tested on my Android 7.0 (Samsung Galaxy S6 edge+) and Android 11 (Vivo X70 Pro+). Both look good.
20211119222432

FYI:
Android Gradle plugin release notes
Gradle Distributions
NDK Downloads
Cannot add task 'wrapper' as a task with that name already exists
How to specify source and target compatibility in Java module?

@feiyunw
Copy link
Author

feiyunw commented Nov 20, 2021

@MeridianOXC
Copy link
Owner

@StoddardOXC can you check if this is compatible with the build farm?

@StoddardOXC
Copy link

Buildfarm worker is now at

  • Android NDK/SDK r19
  • OpenJDK 1.8.0_191-8u191-b12-2ubuntu0

Do we lose any compatability with older devices?
What issues does this upgrade solve?

I can fire up a worker with those versions no problem, but is it worth it?

@StoddardOXC
Copy link

@MeridianOXC Barring any obvious loss of support for older devices I recommend you make a branch with this PR merged, then I fix up a worker and a build for this, then test the resulting artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants