feat(scan): add escrow to AcceptsScheme enum#667
Closed
craigbidenbot[bot] wants to merge 1 commit intomainfrom
Closed
feat(scan): add escrow to AcceptsScheme enum#667craigbidenbot[bot] wants to merge 1 commit intomainfrom
craigbidenbot[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
craigbidenbot
bot
force-pushed
the
craig/add-escrow-scheme
branch
from
39f3760 to
47fd0f8
Compare
craigbidenbot
bot
force-pushed
the
craig/add-escrow-scheme
branch
2 times, most recently
from
17fefe2 to
32985b4
Compare
Adds 'escrow' as a valid payment scheme alongside 'exact'. This unblocks x402r escrow-based endpoints from being indexed by x402scan. Changes: - Prisma enum: add 'escrow' value + migration - Zod validation in resource.ts: accept 'escrow' scheme - Normalized accept schema in x402/index.ts: accept 'escrow' scheme - Type cast in normalizePaymentRequirement: 'exact' | 'escrow' Closes #663
craigbidenbot
bot
force-pushed
the
craig/add-escrow-scheme
branch
from
32985b4 to
42dda63
Compare
craigbidenbot
bot
changed the title
Contributor
Author
|
Closing in favor of #708 from @Sigmabrogz — same fix, community contribution gets priority. God love ya, Sigmabro. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
escrowas a valid payment scheme so x402r escrow-based endpoints can be indexed by x402scan. Currently 36 endpoints from an external contributor are blocked because the schema only acceptsexact.Changes
escrowvalue + SQL migrationresource.ts:z.enum(['exact', 'escrow'])x402/index.ts:z3.enum(['exact', 'escrow'])normalizePaymentRequirement:'exact' | 'escrow'Test Plan
exactscheme endpoints still register and display correctlyescrowscheme endpoints can now be registered via the APIALTER TYPE ... ADD VALUE)Closes #663