Skip to content

fix(scan): prevent OgImage unique constraint conflict on registration (#287) #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xidik12 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(scan): prevent OgImage unique constraint conflict on registration (#287) #730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 50 additions & 21 deletions apps/scan/src/services/db/resources/origin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,30 +46,59 @@ export const upsertOrigin = async (
const originId = upsertedOrigin.id;

await Promise.all(
origin.ogImages.map(({ url, height, width, title, description }) =>
tx.ogImage.upsert({
where: {
originId_url: {
origin.ogImages.map(async ({ url, height, width, title, description }) => {
try {
await tx.ogImage.upsert({
where: {
originId_url: {
originId,
url,
},
},
update: {
height,
width,
title,
description,
},
create: {
originId,
url,
height,
width,
title,
description,
},
},
update: {
height,
width,
title,
description,
},
create: {
originId,
url,
height,
width,
title,
description,
},
})
)
});
} catch (error: unknown) {
// Handle unique constraint violation when the OG image URL already
// exists globally (e.g. shared CDN / redirect across origins).
// Fall back to finding the existing image and connecting it to this
// origin, or simply update metadata if already linked.
const isUniqueViolation =
error instanceof Error &&
'code' in error &&
(error as { code: string }).code === 'P2002';
if (isUniqueViolation) {
Copy link
Copy Markdown
Contributor

@vercel vercel bot Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OgImage upsert silently fails to update metadata when unique constraint violation occurs for an image already belonging to the same origin

Fix on Vercel

const existing = await tx.ogImage.findFirst({ where: { url } });
if (existing && existing.originId !== originId) {
// Image belongs to another origin; create a new entry for this
// origin using the composite key-safe approach.
await tx.ogImage.create({
data: { originId, url, height, width, title, description },
}).catch(() => {
// Already exists for this origin; just update
return tx.ogImage.update({
where: { originId_url: { originId, url } },
data: { height, width, title, description },
});
});
}
} else {
throw error;
}
}
})
);

return tx.resourceOrigin.findUnique({
Expand Down