fix: handle OgImage unique constraint conflict for shared URLs (#287)#767
Open
ledgerpilot wants to merge 1 commit intoMerit-Systems:mainfrom
Open
fix: handle OgImage unique constraint conflict for shared URLs (#287)#767ledgerpilot wants to merge 1 commit intoMerit-Systems:mainfrom
ledgerpilot wants to merge 1 commit intoMerit-Systems:mainfrom
Conversation
Contributor
|
@ledgerpilot is attempting to deploy a commit to the Merit Systems Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #287
Root Cause
When two resources share the same origin (e.g.
https://subdomain.example.com), both registrations callupsertOriginwhich tries to createOgImagerecords for that origin's scraped metadata. If the OG image URL is the same across both calls (e.g. a CDN image used site-wide), the concurrentupsertinsidePromise.allhits the unique constraint on(originId, url)— or a pre-existing DB-level constraint onurl— and throws.Fix
Replace the
Promise.allof parallelogImage.upsertcalls with a sequentialfor…ofloop where each upsert is wrapped in a.catch(). This ensures:resourceOriginupsert always succeeds regardless of OG image conflicts.Changes
apps/scan/src/services/db/resources/origin.ts: sequential upserts with per-record error handling instead ofPromise.all