Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support chat without stream #409

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −9
Open

fix: support chat without stream #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fab4aca
fix: support chat without stream
yugasun Mar 10, 2025
54afacd
fix: remove default stream value for agent
yugasun Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/praisonai-agents/praisonaiagents/agent/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,7 @@ def _chat_completion(self, messages, temperature=0.2, tools=None, stream=True, r
display_error(f"Error in chat completion: {e}")
return None

def chat(self, prompt, temperature=0.2, tools=None, output_json=None, output_pydantic=None, reasoning_steps=False):
def chat(self, prompt, temperature=0.2, tools=None, output_json=None, output_pydantic=None, reasoning_steps=False, stream=None):
# Log all parameter values when in debug mode
if logging.getLogger().getEffectiveLevel() == logging.DEBUG:
param_info = {
Expand Down Expand Up @@ -842,7 +842,7 @@ def chat(self, prompt, temperature=0.2, tools=None, output_json=None, output_pyd
agent_tools=agent_tools
)

response = self._chat_completion(messages, temperature=temperature, tools=tools if tools else None, reasoning_steps=reasoning_steps)
response = self._chat_completion(messages, temperature=temperature, tools=tools if tools else None, reasoning_steps=reasoning_steps, stream=stream)
if not response:
return None

Expand Down Expand Up @@ -879,7 +879,7 @@ def chat(self, prompt, temperature=0.2, tools=None, output_json=None, output_pyd
"content": "Function returned an empty output"
})

response = self._chat_completion(messages, temperature=temperature)
response = self._chat_completion(messages, temperature=temperature, stream=stream)
if not response:
return None
response_text = response.choices[0].message.content.strip()
Expand Down Expand Up @@ -949,7 +949,7 @@ def chat(self, prompt, temperature=0.2, tools=None, output_json=None, output_pyd

logging.debug(f"{self.name} reflection count {reflection_count + 1}, continuing reflection process")
messages.append({"role": "user", "content": "Now regenerate your response using the reflection you made"})
response = self._chat_completion(messages, temperature=temperature, tools=None, stream=True)
response = self._chat_completion(messages, temperature=temperature, tools=None, stream=stream)
response_text = response.choices[0].message.content.strip()
reflection_count += 1
continue # Continue the loop for more reflections
Expand Down Expand Up @@ -1129,7 +1129,7 @@ async def achat(self, prompt: str, temperature=0.2, tools=None, output_json=None
model=self.llm,
messages=messages,
temperature=temperature,
tools=formatted_tools
tools=formatted_tools,
)
result = await self._achat_completion(response, tools)
if logging.getLogger().getEffectiveLevel() == logging.DEBUG:
Expand Down
10 changes: 6 additions & 4 deletions src/praisonai-agents/praisonaiagents/agents/agents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def process_video(video_path: str, seconds_per_frame=2):
return base64_frames

class PraisonAIAgents:
def __init__(self, agents, tasks=None, verbose=0, completion_checker=None, max_retries=5, process="sequential", manager_llm=None, memory=False, memory_config=None, embedder=None, user_id=None, max_iter=10):
def __init__(self, agents, tasks=None, verbose=0, completion_checker=None, max_retries=5, process="sequential", manager_llm=None, memory=False, memory_config=None, embedder=None, user_id=None, max_iter=10, stream=None):
# Add check at the start if memory is requested
if memory:
try:
Expand All @@ -68,15 +68,16 @@ def __init__(self, agents, tasks=None, verbose=0, completion_checker=None, max_r
for agent in agents:
agent.user_id = self.user_id

self.agents = agents
self.tasks = {}
self.agents: List[Agent] = agents
self.tasks: Dict[int, Task] = {}
if max_retries < 3:
max_retries = 3
self.completion_checker = completion_checker if completion_checker else self.default_completion_checker
self.task_id_counter = 0
self.verbose = verbose
self.max_retries = max_retries
self.process = process
self.stream = stream

# Check for manager_llm in environment variable if not provided
self.manager_llm = manager_llm or os.getenv('OPENAI_MODEL_NAME', 'gpt-4o')
Expand Down Expand Up @@ -665,7 +666,8 @@ def _get_multimodal_message(text_prompt, images):
task_prompt,
tools=task.tools,
output_json=task.output_json,
output_pydantic=task.output_pydantic
output_pydantic=task.output_pydantic,
stream=self.stream,
)

if agent_output:
Expand Down