Improve model-fit validation confidence - #1073
Conversation
|
This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
not sure if this will ever work or even if we want it anymore @michaelneale |
|
this one needs a lot of work to bring up to date I think - and that is a LOT of new code - patch queue? |
This PR improves the local model-fit validation path so Mesh LLM can make more honest GGUF fit and throughput claims from metadata plus measured hardware facts. It keeps the fitter deterministic: no model-name shortcuts, no backend correction constants, and no validation-row-specific tuning.
What changed
Why
The goal is a local fitter that can inspect arbitrary Hugging Face GGUF metadata, combine it with mesh-llm gpus benchmark output, and return explainable local fit recommendations. The current direction is to model llama.cpp execution boundaries rather than layer family multipliers or hidden magic constants.
Validation
Note: the release build completed successfully. The build output still reported GGML decode probes disabled for one compile path, so native-probe linkage should be rechecked in the next validation pass before relying on the new Q5_K probe in fresh benchmark runs.
Current confidence
The strongest evidence is still dense quantized GGUFs with known tensor mappings on measured hardware. CUDA quant-ladder rows are near the ±10% target. Metal is improving but remains more guarded, especially for tiny models, MoE, and models where tensor types fall into unknown or surrogate buckets.
Next steps