Skip to content

Provide the V1 tokenizer inventory activation bridge - #1168

Draft
i386 wants to merge 1 commit into
agent/generation-lifecycle-eventsfrom
agent/rosetta-tokenizer-inventory-upstream
Draft

Provide the V1 tokenizer inventory activation bridge#1168
i386 wants to merge 1 commit into
agent/generation-lifecycle-eventsfrom
agent/rosetta-tokenizer-inventory-upstream

Conversation

@i386

@i386 i386 commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Provide the V1 native-serving-plugin activation contract for tokenizer-aware serving plugins.

Design

  • Mesh materializes the complete native vocabulary while binding the source GGUF.
  • ActivationContext carries a borrowed TokenizerInventoryView with native token IDs, byte pieces, and control-token identities.
  • The host-owned view is valid for the activation call. A plugin copies or transforms the vocabulary before activate returns.
  • The V1 plugin table is exported as mesh_native_serving_plugin_v1.
  • Mesh retains ownership of model execution, verification, lifecycle ordering, and the absolute proposal deadline.

Use

A tokenizer-aware plugin can build an immutable native-token table during activation. Vocabulary discovery and table construction therefore complete before the proposal/decode path.

Dependency

This draft is based on #1149, which provides the native serving-plugin host and generation lifecycle.

Validation

  • just with-lld cargo test -p model-artifact -p mesh-native-serving-plugin-host -p skippy-server
  • just with-lld cargo clippy -p model-artifact -p mesh-native-serving-plugin-host -p skippy-server -- -D warnings

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 01431bd7-4d71-49eb-a40c-4570c08b9c7b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

This pull request is currently a draft. Reviews will not take place until the PR is marked as ready for review.

@ndizazzo
ndizazzo force-pushed the agent/generation-lifecycle-events branch from 18aeb33 to 5303997 Compare August 4, 2026 18:59
@ndizazzo
ndizazzo force-pushed the agent/rosetta-tokenizer-inventory-upstream branch from 04efbfa to 05b4afe Compare August 4, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant