Skip to content

fix(xtask): regenerate console-print ratchet drifted 2 lines by #1376 - #1379

Merged
ndizazzo merged 1 commit into
mainfrom
fix/console-print-ratchet-drift
Aug 19, 2026
Merged

fix(xtask): regenerate console-print ratchet drifted 2 lines by #1376#1379
ndizazzo merged 1 commit into
mainfrom
fix/console-print-ratchet-drift

Conversation

@ndizazzo

@ndizazzo ndizazzo commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Problem

main has been red since #1376 merged (3a0cfb3). Main · Quality fails on CI contracts and consistency:

console print ratchet is out of sync with the tree:
crates/mesh-llm-system/src/autoupdate.rs:148 eprintln!: approved occurrence is missing or was replaced
... (11 entries total)

Every one of the 11 allowlisted line numbers for autoupdate.rs in tools/xtask/data/console_print_allowlist.json is exactly 2 lines short of where the corresponding eprintln! actually landed (148→150, 173→175, 195→197, 199→201, 206→208, 295→297, 302→304, 318→320, 324→326, 327→329, 331→333). Both files were touched by #1376 itself, so the ratchet was captured against a tree state 2 lines shorter than what merged.

Fix

cargo run -p xtask -- repo-consistency no-console-print --regen. Diff is scoped to exactly those 11 line-number corrections in the one file — no new/removed allowlist entries, no other file touched.

Validation

  • just ci-validate — clean (was failing on no-console-print before this change)

Found incidentally while starting the CI prebuilt-runner-images work in mesh-dev; unrelated to that effort, filed standalone since it blocks just ci-validate for every PR right now.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated internal console-output allowlist references to match shifted source locations.
    • No user-facing behavior or functionality changed.

Main's Quality gate (Main · Quality, run 32277874638) has been failing
since #1376 merged: every one of the 11 allowlisted eprintln! lines for
crates/mesh-llm-system/src/autoupdate.rs was 2 lines short of where
that macro actually landed in the merged tree (148->150, 173->175, ...
331->333). Both autoupdate.rs and the allowlist were touched by #1376,
so the ratchet was captured against a tree state 2 lines shorter than
what actually landed.

Regenerated via `cargo run -p xtask -- repo-consistency no-console-print
--regen`. Diff is scoped to exactly those 11 line-number corrections —
no new or removed allowlist entries, no other file affected.

Co-authored-by: Claide-Junior <9cdb9620d5e56a5947a467c7e8697fd4800de6617ff592988d4e2c5a1230feb9@buzz>
Signed-off-by: Nick DiZazzo <nick.dizazzo@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ad9cb456-a3c6-4870-afe0-6cf6e2194440

📥 Commits

Reviewing files that changed from the base of the PR and between 3a0cfb3 and 9b05508.

📒 Files selected for processing (1)
  • tools/xtask/data/console_print_allowlist.json

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The console-print allowlist now records shifted source line numbers for ten existing eprintln! occurrences in autoupdate.rs. No source macros or public entities changed.

Changes

Console-print validation metadata

Layer / File(s) Summary
Update allowlist line numbers
tools/xtask/data/console_print_allowlist.json
Updated ten recorded source line numbers for existing eprintln! occurrences in crates/mesh-llm-system/src/autoupdate.rs.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 9b055

This narrowly corrects 11 console-print allowlist line numbers in one file and restores the consistency check; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

Suggested reviewers: michaelneale

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the xtask console-print ratchet fix and the drift caused by PR #1376.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/console-print-ratchet-drift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ndizazzo
ndizazzo merged commit 0f9ebe5 into main Aug 19, 2026
35 checks passed
@ndizazzo
ndizazzo deleted the fix/console-print-ratchet-drift branch August 19, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant