fix(xtask): regenerate console-print ratchet drifted 2 lines by #1376 - #1379
Conversation
Main's Quality gate (Main · Quality, run 32277874638) has been failing since #1376 merged: every one of the 11 allowlisted eprintln! lines for crates/mesh-llm-system/src/autoupdate.rs was 2 lines short of where that macro actually landed in the merged tree (148->150, 173->175, ... 331->333). Both autoupdate.rs and the allowlist were touched by #1376, so the ratchet was captured against a tree state 2 lines shorter than what actually landed. Regenerated via `cargo run -p xtask -- repo-consistency no-console-print --regen`. Diff is scoped to exactly those 11 line-number corrections — no new or removed allowlist entries, no other file affected. Co-authored-by: Claide-Junior <9cdb9620d5e56a5947a467c7e8697fd4800de6617ff592988d4e2c5a1230feb9@buzz> Signed-off-by: Nick DiZazzo <nick.dizazzo@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe console-print allowlist now records shifted source line numbers for ten existing ChangesConsole-print validation metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This narrowly corrects 11 console-print allowlist line numbers in one file and restores the consistency check; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
mainhas been red since #1376 merged (3a0cfb3).Main · Qualityfails onCI contracts and consistency:Every one of the 11 allowlisted line numbers for
autoupdate.rsintools/xtask/data/console_print_allowlist.jsonis exactly 2 lines short of where the correspondingeprintln!actually landed (148→150, 173→175, 195→197, 199→201, 206→208, 295→297, 302→304, 318→320, 324→326, 327→329, 331→333). Both files were touched by #1376 itself, so the ratchet was captured against a tree state 2 lines shorter than what merged.Fix
cargo run -p xtask -- repo-consistency no-console-print --regen. Diff is scoped to exactly those 11 line-number corrections in the one file — no new/removed allowlist entries, no other file touched.Validation
just ci-validate— clean (was failing onno-console-printbefore this change)Found incidentally while starting the CI prebuilt-runner-images work in mesh-dev; unrelated to that effort, filed standalone since it blocks
just ci-validatefor every PR right now.🤖 Generated with Claude Code
Summary by CodeRabbit