Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63de7ab659
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| mapping(address => mapping(uint256 => CertScripState)) certScripStates; | ||
| mapping(address => CertScripUnitPool) certScripUnitPools; | ||
| mapping(address => ScripPoolState) scripPoolStates; | ||
| mapping(address => mapping(address => ScripUserInfo)) scripPoolUsers; | ||
| mapping(address => mapping(address => RecertificationApproval)) | ||
| recertificationApprovals; |
There was a problem hiding this comment.
Because IssuanceManager is upgraded in place (src/IssuanceManager.sol is UUPS-upgradeable, and test/CyberScripUpgradeTest.t.sol exercises proxy upgrades), deleting the two mapping fields above changes the storage slot of recertificationApprovals from the previous implementation. After upgrading an existing proxy, any approvals written before the upgrade will be read from the wrong slot, so pending conversions that previously had approval can start reverting with RecertificationApprovalRequired. Leave the retired mappings in place as unused storage gaps, or add an explicit migration, instead of reordering IssuanceManagerData.
Useful? React with 👍 / 👎.
1 participant
No description provided.