Feat/cert holder cap

[Detoo]

Highlight

• Couldn't implement the logic in IssuanceManager because the legal holder accounting is tightly integrated in CyberCertPrinter._update(). We have no choice but to deal with CyberCertPrinter's size

TODO

• Contract size too large
• Edge cases when upgrading existing CyberCertPrinters with issued certs

╭--------------------------------------------------------------+------------------+-------------------+--------------------+---------------------╮
| Contract                                                     | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
+================================================================================================================================================+
| CyberCertPrinter                                             | 21,055           | 21,262            | 3,521              | 27,890              |
|--------------------------------------------------------------+------------------+-------------------+--------------------+---------------------|
| CyberCertPrinterMock                                         | 5,781            | 6,568             | 18,795             | 42,584              |
|--------------------------------------------------------------+------------------+-------------------+--------------------+---------------------|
| CyberCertPrinterStorage                                      | 6,311            | 6,343             | 18,265             | 42,809              |
|--------------------------------------------------------------+------------------+-------------------+--------------------+---------------------|

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4062e7640

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Prevent underflow when adjusting legacy holder counts

_updateLegalHolder assumes every nonzero owners[tokenId].ownerAddress already has a positive legalHolderTokenCount, but that is false right after upgrading existing printers (new counters start at zero) and after reusing a burned token id (the old owner is still stored). In those cases, s.legalHolderTokenCount[oldOwner] -= 1 underflows and reverts, so legal-owner-changing flows like transfer/assign/burn can become unusable for affected tokens.

Useful? React with 👍 / 👎.