feat: reduce KDF computing cost on clients #6097
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieuartu
added
the
team-identity
|
@metamaskbot publish-preview |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
mirceanis
reviewed
Jul 16, 2025
There was a problem hiding this comment.
Looks good!
Perhaps we can rephrase the changelog to reenforce the reason for this change.
Since this PR deals with encryption "soft" migration I'd take the opportunity to make sure that future "hard" migrations fail gracefully, meaning that clients don't fail entire operations if one of the entries does not decrypt. See lines like if (encryptedData.v === '1').... else throw.
WDYT @mathieuartu ?
mathieuartu
changed the title
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Mrtenz
reviewed
Jul 16, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mirceanis
previously approved these changes
Jul 17, 2025
fabiobozzo
reviewed
Jul 17, 2025
fabiobozzo
previously approved these changes
Jul 17, 2025
|
Converting to draft again because of cache collision issues between older and newer clients. Will update the PR soon |
…ask/core into feat/kdf-performance-2-dumbed-down
mathieuartu
force-pushed
the
feat/kdf-performance-2-dumbed-down
branch
from
159efb2 to
ffa6d7a
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
fabiobozzo
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Nscryptparameter used to compute the encryption key in order to significantly increase performance on clients.The tests below have been done measuring 30 consecutive clean onboardings and the time it took to encrypt or decrypt the first entry (before caching the key from the KDF)
References
Fixes: https://consensyssoftware.atlassian.net/browse/IDENTITY-157
Changelog
Checklist