-
-
Notifications
You must be signed in to change notification settings - Fork 242
Seedless controller: Add "@noble" dependencies as main dependencies #6101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c8788f9
to
d2fe10f
Compare
d2fe10f
to
74026d4
Compare
@@ -49,7 +49,7 @@ | |||
"dependencies": { | |||
"@metamask/base-controller": "^8.0.1", | |||
"@metamask/controller-utils": "^11.11.0", | |||
"@noble/hashes": "^1.4.0", | |||
"@noble/hashes": "^1.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: instead of using no-changelog
could we add a changelog entry for this bump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
"@noble/ciphers": "^1.3.0", | ||
"@noble/hashes": "^1.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: instead of using no-changelog
could we add a changelog entries for these bumps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
"@noble/ciphers": "^1.3.0", | ||
"@noble/curves": "^1.9.2", | ||
"@noble/hashes": "^1.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: instead of using no-changelog
could we add a changelog entries for these bumps and that they are being now used as dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
2983e5c
to
c0e611a
Compare
rebased |
c0e611a
to
29a2046
Compare
Explanation
The dependencies
@noble/hashes
,@noble/ciphers
,@noble/curves
were mistakenly listed as dev-dependencies inseedless-controller
. Moving them to main dependencies here.Also upgrading all
@noble
dependencies to most recent version. In particular,@noble/ciphers
has now a v1 which is audited.References
Changelog
Checklist