Skip to content

Seedless controller: Add "@noble" dependencies as main dependencies #6101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

matthiasgeihs
Copy link
Contributor

@matthiasgeihs matthiasgeihs commented Jul 10, 2025

Explanation

The dependencies @noble/hashes, @noble/ciphers, @noble/curves were mistakenly listed as dev-dependencies in seedless-controller. Moving them to main dependencies here.

Also upgrading all @noble dependencies to most recent version. In particular, @noble/ciphers has now a v1 which is audited.

References

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matthiasgeihs matthiasgeihs requested review from a team as code owners July 10, 2025 14:57
@matthiasgeihs matthiasgeihs force-pushed the mg/fix-seedless-dependencies branch from c8788f9 to d2fe10f Compare July 14, 2025 09:15
@matthiasgeihs matthiasgeihs requested review from a team as code owners July 14, 2025 09:15
@matthiasgeihs matthiasgeihs force-pushed the mg/fix-seedless-dependencies branch from d2fe10f to 74026d4 Compare July 14, 2025 09:27
@matthiasgeihs matthiasgeihs changed the title Seedless controller: Add "@noble/ciphers" and "@noble/curves" as core dependencies Seedless controller: Add "@noble" dependencies as main dependencies Jul 14, 2025
@@ -49,7 +49,7 @@
"dependencies": {
"@metamask/base-controller": "^8.0.1",
"@metamask/controller-utils": "^11.11.0",
"@noble/hashes": "^1.4.0",
"@noble/hashes": "^1.8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: instead of using no-changelog could we add a changelog entry for this bump

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines +106 to +107
"@noble/ciphers": "^1.3.0",
"@noble/hashes": "^1.8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: instead of using no-changelog could we add a changelog entries for these bumps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines +54 to +56
"@noble/ciphers": "^1.3.0",
"@noble/curves": "^1.9.2",
"@noble/hashes": "^1.8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: instead of using no-changelog could we add a changelog entries for these bumps and that they are being now used as dependencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@matthiasgeihs matthiasgeihs force-pushed the mg/fix-seedless-dependencies branch from 2983e5c to c0e611a Compare July 15, 2025 20:16
@matthiasgeihs
Copy link
Contributor Author

rebased

@matthiasgeihs matthiasgeihs force-pushed the mg/fix-seedless-dependencies branch from c0e611a to 29a2046 Compare July 16, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants