feat: add extension settings to PreferencesController #6152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds missing preference properties to the core PreferencesController that currently only exist in the MetaMask Extension's custom implementation. This is a prerequisite for the Extension to migrate from its custom PreferencesController to the core package.
The Extension has accumulated many additional preferences over time that were never added to the core controller. This PR brings the core controller to feature parity by adding:
No behavioral changes - just expanding the state interface to support all preferences currently used by the Extension.
References
Changelog
@metamask/preferences-controller
- BREAKING: ExpandedPreferencesState
interface with additional properties previously only in ExtensionChecklist