chore: remove usages of NetworkController:getState in EarnController #6153
+242
−726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
ameliejyc
changed the title
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ameliejyc
changed the title
ameliejyc
changed the title
ameliejyc
force-pushed
the
TAT-1264-mobile-remove-usage-s-of-global-chain-id-in-earn-experiences
branch
from
243e64f to
8886aa1
Compare
ameliejyc
commented
Jul 21, 2025
Comment on lines
+333
to
+337
| // refresh pooled staking data | ||
| this.refreshPooledStakingVaultMetadata().catch(console.error); | ||
| this.refreshPooledStakingVaultDailyApys().catch(console.error); | ||
| this.refreshPooledStakingVaultApyAverages().catch(console.error); | ||
| this.refreshPooledStakes().catch(console.error); |
There was a problem hiding this comment.
I've left these calls the same here but I don't know if it brings much value to refresh PS data on each network change given PS isn't multi-chain? For the Lending calls below it seems to make more sense.
ameliejyc
force-pushed
the
TAT-1264-mobile-remove-usage-s-of-global-chain-id-in-earn-experiences
branch
from
8886aa1 to
6a9a827
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ameliejyc
force-pushed
the
TAT-1264-mobile-remove-usage-s-of-global-chain-id-in-earn-experiences
branch
from
7853624 to
d05158e
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
7 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Chain ID Typing Mismatch Causes Hex Conversion Errors
Type inconsistency in executeLendingDeposit, executeLendingWithdraw, and executeLendingTokenApprove methods. The chainId parameter is typed as string but is passed to toHex(), which expects a number. This can lead to incorrect behavior if chainId is already a hex string (e.g., '0x1'). The chainId parameter should either be typed as number, or the toHex() call should be removed.
packages/earn-controller/src/EarnController.ts#L872-L928
core/packages/earn-controller/src/EarnController.ts
Lines 872 to 928 in d05158e
packages/earn-controller/src/EarnController.ts#L943-L999
core/packages/earn-controller/src/EarnController.ts
Lines 943 to 999 in d05158e
packages/earn-controller/src/EarnController.ts#L1015-L1071
core/packages/earn-controller/src/EarnController.ts
Lines 1015 to 1071 in d05158e
Bug: Redundant API Calls in Loop
The refreshEarnEligibility() method is redundantly called inside the refreshPooledStakingData() loop for each supported chain. As this method performs a global, address-based eligibility check independent of chain ID, these multiple calls cause unnecessary API requests, performance overhead, and potential race conditions. It should be called once outside the loop.
packages/earn-controller/src/EarnController.ts#L636-L657
core/packages/earn-controller/src/EarnController.ts
Lines 636 to 657 in d05158e
Was this report helpful? Give feedback by reacting with 👍 or 👎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The Global Network Selector is being removed and these changes for the EarnController ensure that we are not relying on global state via
NetworkController:getState. Instead, information required such as the selected network client ID or chain ID is passed in contextually.NetworkController:getState. Instead:selectedNetworkClientIdto be passed in when constructed and it is used ininitializeSDK.chainIdparameter with fallback to Ethereum Mainnet used in Pooled Staking data calls:refreshPooledStakingVaultApyAverages,refreshPooledStakingVaultDailyApys,refreshPooledStakingVaultMetadataandrefreshPooledStakeschainIdparameter required in all Lending transaction calls:executeLendingTokenApprove,executeLendingWithdrawandexecuteLendingDepositchainIdparameter required in Lending data calls:getLendingMarketDailyApysAndAveragesandgetLendingPositionHistory. The other Lending data fetches do not require a chainId.NetworkController:networkDidChangerather thanNetworkController:stateChangeas this is a more granular and less frequent event to listen to.References
Checklist