Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e update spending #17640

Merged
merged 7 commits into from
Feb 7, 2023
Merged

E2e update spending #17640

merged 7 commits into from
Feb 7, 2023

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Feb 7, 2023

Explanation

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [4e9959e]
Page Load Metrics (1119 ± 94 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92154111157
domContentLoaded8831597110819493
load8831598111919794
domInteractive8831597110819493
Bundle size diffs
  • background: 0 bytes
  • ui: 683 bytes
  • common: 0 bytes

@seaona seaona marked this pull request as ready for review February 7, 2023 17:39
@seaona seaona requested a review from a team as a code owner February 7, 2023 17:39
@seaona seaona requested review from segun and removed request for a team February 7, 2023 17:39
@seaona seaona merged commit 5da026f into update-spending-cap Feb 7, 2023
@seaona seaona deleted the e2e-update-spending branch February 7, 2023 17:39
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants