ci: a new prep-deps workflow with caching #29979
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,26 +9,24 @@ on: | |
| branches: | ||
| - main | ||
| schedule: | ||
| - cron: '0 */12 * * *' | ||
|
|
||
| jobs: | ||
| synchronize-with-crowdin: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: crowdin action | ||
| uses: crowdin/github-action@a3160b9e5a9e00739392c23da5e580c6cabe526d | ||
| with: | ||
| upload_translations: true | ||
| download_translations: true | ||
| github_user_name: metamaskbot | ||
| github_user_email: [email protected] | ||
| env: | ||
| GITHUB_ACTOR: metamaskbot | ||
| GITHUB_TOKEN: ${{ secrets.METAMASKBOT_CROWDIN_TOKEN }} | ||
| CROWDIN_PROJECT_ID: ${{ secrets.CROWDIN_PROJECT_ID }} | ||
| CROWDIN_PERSONAL_TOKEN: ${{ secrets.CROWDIN_PERSONAL_TOKEN }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,75 +15,65 @@ on: | |
| merge_group: | ||
|
|
||
| jobs: | ||
| prep-deps: | ||
|
There was a problem hiding this comment. Running Also keep in mind that we need to migrate 40 more workflows. More context here: https://consensys.slack.com/archives/C087GPTR5HQ/p1738658608653149 |
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Setup environment | ||
| uses: metamask/github-tools/.github/actions/setup-environment@caching | ||
| with: | ||
| should-cache-restore: 'false' | ||
| should-cache-save: ${{ vars.USE_CACHING }} | ||
| # -- If you're a repo admin, you can change vars.USE_CACHING at: | ||
| # https://github.com/MetaMask/metamask-extension/settings/variables/actions | ||
| # -- If you're just a contributor, you can change vars.USE_CACHING by following this documentation: | ||
| # https://docs.github.com/en/rest/actions/variables?apiVersion=2022-11-28#update-a-repository-variable | ||
|
|
||
| lint-workflows: | ||
| name: Lint workflows | ||
| uses: metamask/github-tools/.github/workflows/lint-workflows.yml@caching | ||
|
|
||
| test-lint: | ||
| needs: prep-deps | ||
| uses: ./.github/workflows/test-lint.yml | ||
|
|
||
| test-circular-deps: | ||
| name: Test circular deps | ||
| needs: prep-deps | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Setup environment | ||
| uses: metamask/github-tools/.github/actions/setup-environment@caching | ||
| with: | ||
| should-cache-restore: ${{ vars.USE_CACHING }} | ||
|
|
||
| - name: Check circular dependencies | ||
| run: yarn circular-deps:check | ||
|
|
||
| test-short-suite: | ||
| needs: prep-deps | ||
| uses: ./.github/workflows/test-short-suite.yml | ||
|
|
||
| test-storybook: | ||
| name: Test storybook | ||
| needs: prep-deps | ||
| uses: ./.github/workflows/test-storybook.yml | ||
|
|
||
| validate-lavamoat-policy-build: | ||
| needs: prep-deps | ||
| uses: ./.github/workflows/validate-lavamoat-policy-build.yml | ||
|
|
||
| validate-lavamoat-policy-webapp: | ||
| needs: prep-deps | ||
| uses: ./.github/workflows/validate-lavamoat-policy-webapp.yml | ||
|
|
||
| prep-build-test-browserify: | ||
| needs: prep-deps | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Setup environment | ||
| uses: metamask/github-tools/.github/actions/setup-environment@caching | ||
| with: | ||
| should-cache-restore: ${{ vars.USE_CACHING }} | ||
|
|
||
| - run: yarn build:test | ||
|
|
||
|
|
@@ -94,13 +84,13 @@ jobs: | |
| path: ./dist/ | ||
|
|
||
| prep-build-test-webpack: | ||
| needs: prep-deps | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Setup environment | ||
| uses: metamask/github-tools/.github/actions/setup-environment@caching | ||
| with: | ||
| should-cache-restore: ${{ vars.USE_CACHING }} | ||
|
There was a problem hiding this comment. What was the background behind choosing an env variable over harcoding? There was a problem hiding this comment. Pro: It's way fewer lines of code to do it this way. Setting a variable in Con: You lose some control and repeatability of workflows. I'm kind of in a divided mind myself. There was a problem hiding this comment. Ah I see what you mean. Other than slower performance due to the extra yarn install, are there any issues if the settings were accidentally set out out of sync? I suspect most of the time we will want caching for these, and only in the odd case we may set a couple workflows to be There was a problem hiding this comment. If prep-deps had There was a problem hiding this comment. I suppose another option is to just set all of these to There was a problem hiding this comment. I would probably also hard-code |
||
|
|
||
| - run: yarn webpack --test --no-lavamoat --no-cache --browser=chrome --lockdown --sentry --snow --env production | ||
| env: | ||
|
|
@@ -114,6 +104,7 @@ jobs: | |
|
|
||
| run-tests: | ||
| name: Run tests | ||
| needs: prep-deps | ||
| uses: ./.github/workflows/run-tests.yml | ||
|
|
||
| run-benchmarks: | ||
|
|
@@ -171,14 +162,9 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| needs: | ||
| - lint-workflows | ||
| - test-lint | ||
| - test-short-suite | ||
| - test-storybook | ||
| - validate-lavamoat-policy-build | ||
| - validate-lavamoat-policy-webapp | ||
| - run-tests | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not merge the
Checkout repositoryandSetup environmentsteps together. What if there is some occasion where you want only one? Feels like this step is doing too much at once