chore: Bump `eslint-plugin-react-hooks` from `^5.2.0` to `^7.0.1` #38376

MajorLift · 2025-11-28T02:06:31Z

Description

Replace deprecated pre-release react-compiler/react-compiler ruleset with react-hooks
Handle breaking changes from updating two major versions.
Use additionalEffectHooks config field to apply react-hooks/exhaustive-deps rule to custom hooks useAsync{Callback,Result,ResultOrThrow}

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-11-28T02:06:39Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-11-28T02:07:45Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	eslint-plugin-react-hooks@5.2.0 ⏵ 7.0.1				⁺¹

View full report

MajorLift · 2025-11-28T02:08:37Z

@metamaskbot update-policies

metamaskbot · 2025-11-28T02:24:56Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-11-28T02:25:50Z

✨ Files requiring CODEOWNER review ✨

🧩 @MetaMask/extension-devs (1 files, +57 -1)

📁 lavamoat/
- 📁 build-system/
  - 📄 policy.json +57 -1

📜 @MetaMask/policy-reviewers (1 files, +57 -1)

📁 lavamoat/
- 📁 build-system/
  - 📄 policy.json +57 -1

Tip

Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers.

🔗 @MetaMask/supply-chain (1 files, +57 -1)

📁 lavamoat/
- 📁 build-system/
  - 📄 policy.json +57 -1

metamaskbot · 2025-11-28T13:50:43Z

Builds ready [df0041f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1239 ± 122 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1239	1041	1571	122	1330	1458
			load	1038	861	1299	105	1107	1243
			domContentLoaded	1032	858	1293	103	1101	1234
			domInteractive	26	16	96	20	22	82
			firstPaint	533	93	1269	402	1002	1171
			backgroundConnect	212	191	269	12	217	235
			firstReactRender	31	21	62	9	36	54
			getState	38	16	118	19	45	83
			initialActions	1	0	11	1	1	3
			loadScripts	826	660	1087	100	895	1024
			setupStore	12	5	43	6	13	25
			numNetworkReqs	12	5	78	20	5	73
	Browserify	Power User Home	uiStartup	2062	1750	2674	223	2167	2537
			load	1033	908	1417	110	1024	1318
			domContentLoaded	1018	901	1404	109	1015	1311
			domInteractive	36	19	132	25	35	116
			firstPaint	559	132	1421	387	976	1281
			backgroundConnect	260	201	761	106	234	554
			firstReactRender	60	42	107	13	66	84
			getState	189	132	727	60	204	230
			initialActions	1	0	4	1	1	2
			loadScripts	807	697	1192	108	802	1103
			setupStore	21	10	76	11	24	46
			numNetworkReqs	102	66	273	50	95	259
	Webpack	Standard Home	uiStartup	808	699	1161	79	826	976
			load	626	563	904	66	649	787
			domContentLoaded	621	560	896	66	644	778
			domInteractive	26	15	125	21	22	78
			firstPaint	272	79	784	191	319	657
			backgroundConnect	10	5	72	8	10	19
			firstReactRender	27	20	45	6	31	38
			getState	27	13	72	11	35	47
			initialActions	1	0	3	1	1	1
			loadScripts	619	557	886	64	642	769
			setupStore	10	6	20	3	12	16
			numNetworkReqs	12	5	77	20	5	73
	Webpack	Power User Home	uiStartup	1673	1367	2599	271	1957	2183
			load	693	592	1241	112	696	967
			domContentLoaded	683	584	1234	112	692	957
			domInteractive	38	17	196	34	33	135
			firstPaint	276	96	929	185	273	687
			backgroundConnect	47	8	579	116	18	488
			firstReactRender	63	44	101	10	69	82
			getState	183	130	731	59	189	227
			initialActions	1	0	4	1	1	2
			loadScripts	680	582	1225	110	690	948
			setupStore	22	10	70	12	24	48
			numNetworkReqs	168	67	427	84	219	415
Firefox	Browserify	Standard Home	uiStartup	1292	1040	1880	180	1405	1725
			load	1058	897	1377	110	1137	1276
			domContentLoaded	1057	896	1377	110	1137	1276
			domInteractive	55	31	131	29	69	114
			firstPaint	-	-	-	-	-	-
			backgroundConnect	46	21	256	41	42	149
			firstReactRender	25	18	54	8	25	45
			getState	12	7	89	11	10	20
			initialActions	1	0	3	1	1	2
			loadScripts	1027	881	1328	94	1097	1217
			setupStore	21	6	249	43	11	146
			numNetworkReqs	11	5	68	16	6	62
	Browserify	Power User Home	uiStartup	2624	2051	4846	464	2745	4016
			load	1195	970	2712	252	1181	1628
			domContentLoaded	1195	969	2711	252	1181	1628
			domInteractive	127	33	627	130	108	468
			firstPaint	-	-	-	-	-	-
			backgroundConnect	115	34	1527	158	110	314
			firstReactRender	61	38	276	27	61	99
			getState	284	87	908	232	365	825
			initialActions	4	0	43	8	2	34
			loadScripts	1150	947	2520	205	1151	1532
			setupStore	156	8	935	184	150	569
			numNetworkReqs	100	59	246	60	79	239
	Webpack	Standard Home	uiStartup	1479	1265	1862	143	1564	1792
			load	1225	1065	1604	111	1302	1414
			domContentLoaded	1225	1065	1603	111	1301	1414
			domInteractive	55	27	139	31	76	117
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	17	154	25	45	107
			firstReactRender	27	20	83	9	27	37
			getState	14	6	151	17	13	40
			initialActions	1	0	2	0	2	2
			loadScripts	1196	1049	1538	102	1274	1388
			setupStore	17	5	256	30	14	45
			numNetworkReqs	12	5	73	17	7	63
	Webpack	Power User Home	uiStartup	3172	2157	5756	843	3408	5004
			load	1612	1203	3415	519	1708	3018
			domContentLoaded	1611	1203	3415	519	1708	3018
			domInteractive	135	31	1124	162	111	499
			firstPaint	-	-	-	-	-	-
			backgroundConnect	175	23	1210	216	163	426
			firstReactRender	70	44	232	31	70	152
			getState	262	70	1113	218	322	806
			initialActions	4	0	94	11	2	6
			loadScripts	1541	1176	3228	443	1677	2829
			setupStore	140	10	1133	186	154	606
			numNetworkReqs	101	62	251	61	79	243

📊 Page Load Benchmark Results

Current Commit: df0041f | Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.03s (±56ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
domContentLoaded-> current mean value: 722ms (±53ms) 🟢 | historical mean value: 728ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 76ms (±10ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.03s	56ms	1.01s	1.33s	1.07s	1.33s
domContentLoaded	722ms	53ms	699ms	1.02s	752ms	1.02s
firstPaint	76ms	10ms	60ms	160ms	88ms	160ms
firstContentfulPaint	76ms	10ms	60ms	160ms	88ms	160ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.21 KiB (0.03%)
ui: 11.61 KiB (0.15%)
common: 9.58 KiB (0.11%)

…mended`

MajorLift · 2025-11-28T21:43:22Z

@metamaskbot update-policies

metamaskbot · 2025-11-28T21:59:17Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-11-28T22:31:54Z

Builds ready [c5d7a56]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
lavamoat build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1235 ± 107 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1235	1016	1560	107	1295	1478
			load	1035	861	1360	99	1091	1219
			domContentLoaded	1028	856	1353	97	1085	1198
			domInteractive	28	16	184	27	21	81
			firstPaint	529	89	1300	417	991	1173
			backgroundConnect	215	197	263	14	223	245
			firstReactRender	30	19	82	11	34	56
			getState	38	15	138	19	44	66
			initialActions	1	0	6	1	1	3
			loadScripts	820	652	1097	94	875	983
			setupStore	13	6	32	5	13	24
			numNetworkReqs	12	5	78	21	5	75
	Browserify	Power User Home	uiStartup	2033	1681	3144	265	2114	2548
			load	1010	882	1782	138	1000	1359
			domContentLoaded	995	876	1736	137	978	1336
			domInteractive	35	18	150	29	34	130
			firstPaint	553	116	1787	393	971	1296
			backgroundConnect	270	197	729	126	232	599
			firstReactRender	57	41	104	14	61	93
			getState	179	141	248	23	197	227
			initialActions	1	0	4	1	1	3
			loadScripts	790	685	1524	137	775	1130
			setupStore	20	10	43	7	23	39
			numNetworkReqs	155	66	408	77	206	320
	Webpack	Standard Home	uiStartup	819	693	1096	88	848	1019
			load	639	566	878	81	669	820
			domContentLoaded	635	561	869	80	665	815
			domInteractive	26	14	109	21	22	90
			firstPaint	219	78	874	154	204	583
			backgroundConnect	11	4	45	8	14	27
			firstReactRender	29	20	239	22	31	38
			getState	26	14	68	11	33	45
			initialActions	1	0	6	1	1	1
			loadScripts	632	558	860	78	663	805
			setupStore	10	6	21	3	12	17
			numNetworkReqs	12	5	76	20	5	74
	Webpack	Power User Home	uiStartup	1645	1257	2530	280	1913	2151
			load	679	581	1359	115	680	944
			domContentLoaded	669	576	1349	115	666	938
			domInteractive	37	17	245	36	30	127
			firstPaint	284	96	960	213	263	903
			backgroundConnect	70	7	663	161	19	555
			firstReactRender	60	42	89	8	65	77
			getState	182	143	656	69	183	212
			initialActions	1	0	3	1	1	2
			loadScripts	667	574	1340	113	664	929
			setupStore	21	8	58	12	24	46
			numNetworkReqs	170	66	424	83	220	408
Firefox	Browserify	Standard Home	uiStartup	1283	1079	1727	147	1363	1615
			load	1069	912	1424	100	1126	1275
			domContentLoaded	1068	911	1423	100	1126	1275
			domInteractive	54	31	152	29	82	118
			firstPaint	-	-	-	-	-	-
			backgroundConnect	42	21	165	23	46	93
			firstReactRender	22	18	41	4	23	35
			getState	13	7	148	19	10	23
			initialActions	1	0	2	0	1	2
			loadScripts	1042	897	1344	92	1097	1250
			setupStore	13	6	143	15	11	34
			numNetworkReqs	11	5	66	16	7	63
	Browserify	Power User Home	uiStartup	2551	1909	4118	481	2702	3801
			load	1140	935	2371	192	1148	1486
			domContentLoaded	1139	929	2370	192	1148	1485
			domInteractive	115	34	465	99	110	402
			firstPaint	-	-	-	-	-	-
			backgroundConnect	95	24	405	69	107	248
			firstReactRender	58	38	144	16	60	90
			getState	241	68	958	188	244	682
			initialActions	2	0	28	3	2	3
			loadScripts	1109	916	2232	177	1114	1416
			setupStore	159	7	789	194	197	649
			numNetworkReqs	99	61	256	58	79	234
	Webpack	Standard Home	uiStartup	1482	1280	2191	158	1554	1755
			load	1228	1077	1580	103	1281	1423
			domContentLoaded	1228	1076	1580	103	1280	1423
			domInteractive	63	27	229	38	81	139
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	21	248	36	49	126
			firstReactRender	26	20	68	6	28	38
			getState	12	7	62	9	12	22
			initialActions	1	0	2	1	2	2
			loadScripts	1203	1050	1550	98	1259	1373
			setupStore	12	5	54	9	14	35
			numNetworkReqs	11	5	65	15	7	54
	Webpack	Power User Home	uiStartup	2875	2087	5450	669	2921	4520
			load	1469	1184	2772	398	1486	2503
			domContentLoaded	1468	1184	2772	398	1486	2503
			domInteractive	101	30	473	86	90	355
			firstPaint	-	-	-	-	-	-
			backgroundConnect	128	29	932	146	137	237
			firstReactRender	64	41	182	22	65	112
			getState	270	57	1051	235	359	835
			initialActions	2	1	25	2	2	3
			loadScripts	1413	1151	2726	354	1457	2371
			setupStore	105	9	676	132	105	396
			numNetworkReqs	102	61	252	61	79	242

📊 Page Load Benchmark Results

Current Commit: c5d7a56 | Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±53ms) 🟡 | historical mean value: 1.04s ⬆️ (historical data)
domContentLoaded-> current mean value: 731ms (±50ms) 🟢 | historical mean value: 724ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 81ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	53ms	1.02s	1.34s	1.09s	1.34s
domContentLoaded	731ms	50ms	702ms	1.00s	757ms	1.00s
firstPaint	77ms	11ms	60ms	168ms	88ms	168ms
firstContentfulPaint	77ms	11ms	60ms	168ms	88ms	168ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 58 Bytes (0%)
ui: 0 Bytes (0%)
common: 20 Bytes (0%)

metamaskbot added the team-extension-platform Extension Platform team label Nov 28, 2025

github-actions bot added the size-XS label Nov 28, 2025

github-actions bot added size-S and removed size-XS labels Nov 28, 2025

MajorLift force-pushed the jongsun/chore/lint/bump-eslint-plugin-react-hooks-to-v7 branch from 1c090f1 to df0041f Compare November 28, 2025 13:10

MajorLift and others added 4 commits November 28, 2025 16:42

Bump eslint-plugin-react-hooks from ^5.2.0 to ^6.1.1

dc993b9

Update LavaMoat policies

c36fe5f

Manually configure lint entries provided by `plugin:react-hooks/recom…

07de5fa

…mended`

Bump eslint-plugin-react-hooks from ^6.1.1 to ^7.0.1

402c831

MajorLift force-pushed the jongsun/chore/lint/bump-eslint-plugin-react-hooks-to-v7 branch from df0041f to 402c831 Compare November 28, 2025 21:43

Update LavaMoat policies

c5d7a56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: Bump `eslint-plugin-react-hooks` from `^5.2.0` to `^7.0.1` #38376

chore: Bump `eslint-plugin-react-hooks` from `^5.2.0` to `^7.0.1` #38376

MajorLift commented Nov 28, 2025 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

socket-security bot commented Nov 28, 2025 •

edited

Loading

Uh oh!

MajorLift commented Nov 28, 2025

Uh oh!

metamaskbot commented Nov 28, 2025

Uh oh!

metamaskbot commented Nov 28, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Nov 28, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

MajorLift commented Nov 28, 2025

Uh oh!

metamaskbot commented Nov 28, 2025

Uh oh!

metamaskbot commented Nov 28, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore: Bump eslint-plugin-react-hooks from ^5.2.0 to ^7.0.1 #38376

Are you sure you want to change the base?

chore: Bump eslint-plugin-react-hooks from ^5.2.0 to ^7.0.1 #38376

Conversation

MajorLift commented Nov 28, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

socket-security bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MajorLift commented Nov 28, 2025

Uh oh!

metamaskbot commented Nov 28, 2025

Uh oh!

metamaskbot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Nov 28, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

MajorLift commented Nov 28, 2025

Uh oh!

metamaskbot commented Nov 28, 2025

Uh oh!

metamaskbot commented Nov 28, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore: Bump `eslint-plugin-react-hooks` from `^5.2.0` to `^7.0.1` #38376

chore: Bump `eslint-plugin-react-hooks` from `^5.2.0` to `^7.0.1` #38376

MajorLift commented Nov 28, 2025 •

edited by github-actions bot

Loading

socket-security bot commented Nov 28, 2025 •

edited

Loading

metamaskbot commented Nov 28, 2025 •

edited

Loading