feat: Design upgrades for Confirmations #38399
Merged
+141
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (24 files, +99 -99)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Collaborator
Builds ready [f43f1ad]
UI Startup Metrics (1230 ± 110 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
dan437
force-pushed
the
confirmations-design-upgrades
branch
from
f43f1ad to
f6710de
Compare
dan437
force-pushed
the
confirmations-design-upgrades
branch
from
f6710de to
3d1e7d3
Compare
matthewwalsh0
previously approved these changes
Nov 28, 2025
...onfirmations/components/confirm/info/typed-sign-v1/__snapshots__/typed-sign-v1.test.tsx.snap
Show resolved
Hide resolved
OGPoyraz
previously approved these changes
Nov 28, 2025
Collaborator
Builds ready [658febb]
UI Startup Metrics (1197 ± 98 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [e4df7e9]
UI Startup Metrics (1226 ± 109 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
dan437
force-pushed
the
confirmations-design-upgrades
branch
from
e4df7e9 to
ac7421c
Compare
Signed-off-by: dan437 <[email protected]>
Signed-off-by: dan437 <[email protected]>
Collaborator
Builds ready [5d1dd33]
UI Startup Metrics (1246 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
approved these changes
Dec 1, 2025
matthewwalsh0
approved these changes
Dec 1, 2025
metamaskbot
added
the
release-13.13.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few design upgrades for Confirmations:
Changelog
CHANGELOG entry: feat: Design upgrades for Confirmations
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5279
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Polishes Confirmations UI by softening key label color/weight, adding 16px spacing between header icons, and making inline alerts transparent when no text (with text rendered only when provided).
TextColor.textAlternative; key text set toTextVariant.bodyMdMediumacross info rows and components (e.g.,getAlertTextColors,BalanceChangeRow).gap={4}(16px) between the account info and advanced details buttons; removed right margin fromAdvancedDetailsButtoncontainer.textOverrideis provided; applyinline-alert__transparent-background(transparent background) when no text; added SCSS modifier; removed default i18n label.Written by Cursor Bugbot for commit 5d1dd33. This will update automatically on new commits. Configure here.