Skip to content

Conversation

@montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Nov 28, 2025

Description

This PR adds tags to btc addresses in the hover address list.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Adds btc address tags to btc addresses in the hover address list.

Related issues

Fixes:

Manual testing steps

  1. Open the wallet
  2. Hover over the network icons
  3. See the btc address with a btc address type tag

Screenshots/Recordings

Before

Screenshot 2025-11-28 at 22 36 49

After

Screenshot 2025-11-28 at 22 24 30

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Adds BTC address-type tags (Legacy, Nested SegWit, Native SegWit, Taproot) to hovered multichain address rows with i18n support and tests.

  • UI (multichain-aggregated-list-row):
    • Compute BTC mainnet address type via bitcoin-address-validation (getAddressInfo, AddressType) and render a Tag (Legacy/Nested SegWit/Native SegWit/Taproot) next to groupName.
    • Simplify groupName logic to prefer Ethereum for EVM CAIP IDs; remove Bitcoin-specific override.
  • i18n:
    • Add messages.json keys: networkNameBitcoinLegacy, networkNameBitcoinNestedSegwit, networkNameBitcoinTaproot; shorten networkNameBitcoinSegwit label to "Native SegWit".
  • Tests:
    • Add test cases verifying tag rendering for BTC P2PKH/P2SH/P2WPKH/P2TR, absence on non-BTC, and coexistence with group name; update i18n mock accordingly.

Written by Cursor Bugbot for commit c98c680. This will update automatically on new commits. Configure here.

@montelaidev montelaidev requested a review from a team as a code owner November 28, 2025 14:36
@montelaidev montelaidev self-assigned this Nov 28, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-accounts-framework Accounts Framework team label Nov 28, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (2 files, +153 -8)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain-accounts/
        • 📁 multichain-address-rows-hovered-list/
          • 📄 multichain-aggregated-list-row.test.tsx +129 -4
          • 📄 multichain-aggregated-list-row.tsx +24 -4

@metamaskbot
Copy link
Collaborator

Builds ready [c98c680]
UI Startup Metrics (1191 ± 101 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup11911029144610112621399
load100085612198610451176
domContentLoaded99485112168510421168
domInteractive2414111182275
firstPaint4647411803789711148
backgroundConnect21018625912216236
firstReactRender30195783347
getState3618119184071
initialActions104112
loadScripts789655101283836964
setupStore1162841219
numNetworkReqs1257720572
BrowserifyPower User HomeuiStartup------
load------
domContentLoaded------
domInteractive------
firstPaint------
backgroundConnect------
firstReactRender------
getState------
initialActions------
loadScripts------
setupStore------
numNetworkReqs------
WebpackStandard HomeuiStartup88371512451079641084
load684574106397734859
domContentLoaded679570105697730853
domInteractive29151132523107
firstPaint20884898141208616
backgroundConnect13585151340
firstReactRender2921133123243
getState271466113649
initialActions103111
loadScripts676568105395728851
setupStore1062841117
numNetworkReqs1257720573
WebpackPower User HomeuiStartup17141326240427619912178
load6865841047103685962
domContentLoaded6765761041104674956
domInteractive40182534133148
firstPaint299101901189378681
backgroundConnect86864517919558
firstReactRender624494116785
getState19113169789186221
initialActions104112
loadScripts6735741032102672948
setupStore22983142352
numNetworkReqs1866342783219414
FirefoxBrowserifyStandard HomeuiStartup12591039172813813391546
load104089613069510971261
domContentLoaded103989213069510961261
domInteractive56311342880114
firstPaint------
backgroundConnect48222653953145
firstReactRender23175062436
getState125143161022
initialActions103122
loadScripts101088012898210581178
setupStore115569933
numNetworkReqs1156616664
BrowserifyPower User HomeuiStartup25891969520353627043963
load1204960266731511411628
domContentLoaded1204960266731511411628
domInteractive12335586115108459
firstPaint------
backgroundConnect109251216124109237
firstReactRender6037178216395
getState274761101216326753
initialActions218123
loadScripts1162942245926811201571
setupStore1599774178185544
numNetworkReqs100573337077310
WebpackStandard HomeuiStartup14891263197613815471809
load1226108214158212781400
domContentLoaded1226108214158212781399
domInteractive60271843487122
firstPaint------
backgroundConnect46181622745117
firstReactRender26206362735
getState156194241340
initialActions102122
loadScripts1199106413937712571332
setupStore12667101235
numNetworkReqs1156415757
WebpackPower User HomeuiStartup29852246615773530824789
load14321112306038214042669
domContentLoaded14311111306038214042669
domInteractive1092950910499396
firstPaint------
backgroundConnect162281183220155877
firstReactRender67422853568102
getState26182917212269771
initialActions3038428
loadScripts13611094303228713621789
setupStore1707760209212656
numNetworkReqs100602535980242
📊 Page Load Benchmark Results

Current Commit: c98c680 | Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±40ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 724ms (±37ms) 🟢 | historical mean value: 726ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 77ms (±11ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 40ms 1.01s 1.29s 1.09s 1.29s
domContentLoaded 724ms 37ms 697ms 975ms 753ms 975ms
firstPaint 77ms 11ms 60ms 172ms 84ms 172ms
firstContentfulPaint 77ms 11ms 60ms 172ms 84ms 172ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 2.14 KiB (0.03%)
  • common: 159 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-M team-accounts-framework Accounts Framework team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants