Closed
Conversation
Contributor
Author
|
@Pvsaint Pls review |
Pvsaint
requested changes
Jul 27, 2025
| </button> | ||
|
|
||
| <div className="flex items-center gap-3"> | ||
| <ThemeToggle /> |
Contributor
There was a problem hiding this comment.
The theme toggle function is broken, please fix!
| const Header: React.FC<HeaderProps> = ({ | ||
| onMenuClick, | ||
| isCollapsed, | ||
| onToggleCollapse, |
Contributor
There was a problem hiding this comment.
The sidebar toggle is broken please fix!
Contributor
Author
|
Will be fixed in another PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #41
Description
This pull request introduces the integration of StarknetKit into the dApp to enable seamless multiple wallet connections for Starknet-compatible wallets.
Key Changes
✅ Integrated StarknetKit to manage wallet connectivity
🔄 Refactored wallet connection logic to support multiple providers
🧪 Added basic handling for connection events (connect/disconnect)
🛠️ Improved UX by updating UI states based on wallet connection status
Why This Change?
Previously, the dApp supported only limited wallet connectivity. With StarknetKit integration:
Users can connect using Argent X, Braavos, and other supported wallets
Developers gain access to a more scalable and modular wallet handling architecture
It enhances user onboarding and accessibility in the Starknet ecosystem
Testing & Validation
Connected with Argent X and Braavos successfully
Verified account address retrieval and state updates
Confirmed UI responsiveness during wallet interactions
Ensured backward compatibility with existing dApp logic