Skip to content

fix: CodeRabbit review fixes for Layer 3 (missed by the #2 merge) - #3

Merged
Mhemd139 merged 1 commit into
mainfrom
feat/layer3-behavioral-probes
Jul 2, 2026
Merged

fix: CodeRabbit review fixes for Layer 3 (missed by the #2 merge)#3
Mhemd139 merged 1 commit into
mainfrom
feat/layer3-behavioral-probes

Conversation

@Mhemd139

@Mhemd139 Mhemd139 commented Jul 2, 2026

Copy link
Copy Markdown
Owner

@
PR #2 was merged from a stale head — the review-fix commit e0f592a (pushed after CI green) was left out. This PR brings it into main.

Fixes from the CodeRabbit round:

  • fingerprint() raises CovenantError (clean exit 2, no stack trace)
  • _check_probes judges probes by probe_key identity, not tool name
  • config: [judge] must be a table (ConfigError, not AttributeError)
  • judge: reject non-boolean drift verdicts
  • introspect: name the probe on a failed call_tool
  • README: document the sample stored for --judge

🤖 Generated with Claude Code
@

- fingerprint() raises CovenantError (not ValueError) so a non-JSON probe
  result exits 2 with one clean line instead of a stack trace, on both the
  snapshot and check paths
- _check_probes judges each live probe by its probe_key identity, so a clean
  probe is no longer skipped when a sibling probe on the same tool drifts
- config: guard that [judge] is a table before .get() — a malformed judge = "x"
  now raises ConfigError, not a raw AttributeError
- judge: reject a non-boolean drift so a stringy "false" cannot mint a spurious
  DEGRADED verdict
- introspect: name the probe on a failed call_tool so a config typo reads as a
  probe error, not a generic connection error
- README: note the lock also stores a sample response for --judge

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Mhemd139, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 669e1ebe-fabc-420a-9dcb-ee72fd0cf4c4

📥 Commits

Reviewing files that changed from the base of the PR and between fff1cd3 and e0f592a.

📒 Files selected for processing (7)
  • README.md
  • covenant/cli.py
  • covenant/config.py
  • covenant/fingerprint.py
  • covenant/introspect.py
  • covenant/judge/__init__.py
  • tests/test_fingerprint.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/layer3-behavioral-probes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Mhemd139
Mhemd139 merged commit 88b60d6 into main Jul 2, 2026
5 checks passed
@Mhemd139
Mhemd139 deleted the feat/layer3-behavioral-probes branch July 4, 2026 14:58
Mhemd139 added a commit that referenced this pull request Jul 4, 2026
fix: CodeRabbit review fixes for Layer 3 (missed by the #2 merge)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant