Resolved #20: Incorrect DeletePlatformCredential signature

MichaelGrafnetter · Nov 14, 2024 · ebe5fb5 · ebe5fb5
1 parent 0474752
commit ebe5fb5
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 12 deletions.
diff --git a/Documentation/CHANGELOG.md b/Documentation/CHANGELOG.md
@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
+## [1.0.5] - 2024-11-14
+
+### Fixed
+
+- Resolved a bug which prevented the `DeletePlatformCredential()` method from working. (Thanks @aseigler for reporting it.)
+- Upgraded System.Text.Json to mitigate [CVE-2024-43485](https://msrc.microsoft.com/update-guide/vulnerability/CVE-2024-43485).
+
 ## [1.0.4] - 2024-10-06
 
 ### Added
@@ -34,7 +41,8 @@ All notable changes to this project will be documented in this file. The format
 
 - Initial version
 
-[Unreleased]: https://github.com/MichaelGrafnetter/webauthn-interop/compare/v1.0.4...HEAD
+[Unreleased]: https://github.com/MichaelGrafnetter/webauthn-interop/compare/v1.0.5...HEAD
+[1.0.4]: https://github.com/MichaelGrafnetter/webauthn-interop/compare/v1.0.4...v1.0.5
 [1.0.4]: https://github.com/MichaelGrafnetter/webauthn-interop/compare/v1.0.3...v1.0.4
 [1.0.3]: https://github.com/MichaelGrafnetter/webauthn-interop/compare/v1.0.2...v1.0.3
 [1.0.2]: https://github.com/MichaelGrafnetter/webauthn-interop/compare/v1.0...v1.0.2

diff --git a/Src/DSInternals.Win32.WebAuthn.Adapter/DSInternals.Win32.WebAuthn.Adapter.csproj b/Src/DSInternals.Win32.WebAuthn.Adapter/DSInternals.Win32.WebAuthn.Adapter.csproj
@@ -6,12 +6,13 @@
     <PackageId>DSInternals.Win32.WebAuthn.Adapter</PackageId>
     <Product>WebAuthn Interop Assembly Adapter</Product>
     <Title>WebAuthn Interop Assembly Adapter</Title>
-    <Version>1.0.4</Version>
-    <AssemblyVersion>1.0.4</AssemblyVersion>
-    <ProductVersion>1.0.4</ProductVersion>
-    <FileVersion>1.0.4</FileVersion>
+    <Version>1.0.5</Version>
+    <AssemblyVersion>1.0.5</AssemblyVersion>
+    <ProductVersion>1.0.5</ProductVersion>
+    <FileVersion>1.0.5</FileVersion>
     <Description>Bridge between Fido2.Models and DSInternals.Win32.WebAuthn packages</Description>
-    <PackageReleaseNotes>- Added EdDSA support.
+    <PackageReleaseNotes>- Resolved a bug which prevented the DeletePlatformCredential() method from working.
+- Upgraded System.Text.Json to mitigate CVE-2024-43485.
 - Windows 10 1903 or newer is required.</PackageReleaseNotes>
   </PropertyGroup>
 

diff --git a/Src/DSInternals.Win32.WebAuthn/DSInternals.Win32.WebAuthn.csproj b/Src/DSInternals.Win32.WebAuthn/DSInternals.Win32.WebAuthn.csproj
@@ -8,12 +8,13 @@
     <PackageId>DSInternals.Win32.WebAuthn</PackageId>
     <Product>WebAuthn Interop Assembly</Product>
     <Title>WebAuthn Interop Assembly</Title>
-    <Version>1.0.4</Version>
-    <AssemblyVersion>1.0.4</AssemblyVersion>
-    <ProductVersion>1.0.4</ProductVersion>
-    <FileVersion>1.0.4</FileVersion>
+    <Version>1.0.5</Version>
+    <AssemblyVersion>1.0.5</AssemblyVersion>
+    <ProductVersion>1.0.5</ProductVersion>
+    <FileVersion>1.0.5</FileVersion>
     <Description>FIDO2 / W3C Web Authentication .NET Library for Windows Desktop and CLI Applications</Description>
-    <PackageReleaseNotes>- Added EdDSA support.
+    <PackageReleaseNotes>- Resolved a bug which prevented the DeletePlatformCredential() method from working.
+- Upgraded System.Text.Json to mitigate CVE-2024-43485.
 - Windows 10 1903 or newer is required.
 - A standalone package providing an adapter for data model defined in Fido2.Models is also available.</PackageReleaseNotes>
   </PropertyGroup>

diff --git a/Src/DSInternals.Win32.WebAuthn/Interop/NativeMethods.cs b/Src/DSInternals.Win32.WebAuthn/Interop/NativeMethods.cs
@@ -152,7 +152,7 @@ out AssertionSafeHandle assertion
         /// <returns>If the function succeeds, it returns S_OK. If the function fails, it returns an HRESULT value that indicates the error.</returns>
         [DllImport(WebAuthn, EntryPoint = "WebAuthNDeletePlatformCredential")]
         [DefaultDllImportSearchPaths(DllImportSearchPath.System32)]
-        public static extern HResult DeletePlatformCredential(int credentialIdLength, in byte[] credentialId);
+        public static extern HResult DeletePlatformCredential(int credentialIdLength, byte[] credentialId);
 
 
         /// <summary>