Skip to content

Conversation

@ManikaDhiman
Copy link
Contributor

No description provided.

@prmerger-automator
Copy link
Contributor

@ManikaDhiman : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 1ac6938:

✅ Validation status: passed

File Status Preview URL Details
azure-local/manage/upgrade-sdn.md ✅Succeeded
azure-local/TOC.yml ✅Succeeded

For more details, please refer to the build report.

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

@v-dirichards
Copy link
Contributor

v-dirichards commented Nov 20, 2025

@alkohli

Can you review the proposed changes?

If you approve the new content in this PR, the commits must be moved to the private repository for automated checks and publishing. After you move the commits, close this PR (#please-close). If you need help moving the commits, contact the publicprs alias.

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Nov 20, 2025
@MicrosoftDocs MicrosoftDocs deleted a comment from prmerger-automator bot Nov 20, 2025
Copilot finished reviewing on behalf of v-dirichards November 20, 2025 21:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive documentation for upgrading Software Defined Networking (SDN) infrastructure managed by on-premises tools in Azure Local environments. The documentation provides step-by-step procedures for safely upgrading various SDN components and includes troubleshooting guidance for common issues.

Key Changes

  • New how-to guide covering in-place OS upgrades for SDN infrastructure components including Hyper-V hosts, Network Controller VMs, Load Balancer Multiplexers, and Gateway VMs
  • Detailed PowerShell-based workflows with code examples for each upgrade scenario
  • Troubleshooting section addressing common upgrade issues like Service Fabric node health, DNS resolution, and configuration state failures

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 14 comments.

File Description
azure-local/manage/upgrade-sdn.md New documentation file providing complete upgrade procedures for SDN infrastructure with prerequisite steps, component-specific upgrade workflows, and troubleshooting guidance
azure-local/TOC.yml Adds table of contents entry for the new upgrade documentation, positioned logically after the existing "Update SDN infrastructure" entry

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# /dynamicupdate enables the download of updates during the upgrade process.
# added " /quiet" and " /EULA accept" to arguments for the setup.exe command, to suppress the GUI and accept the EULA.

Start-Process -FilePath "$DVDDrive\setup.exe" -ArgumentList "/auto upgrade /dynamicupdate enable /copylogs $logDir /quiet /eula accept"
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command Start-Process is called without the -Wait parameter. This means the script will continue immediately without waiting for the upgrade to complete, which could cause issues with subsequent steps. Consider adding -Wait to ensure the upgrade finishes before proceeding:

Start-Process -FilePath "$DVDDrive\setup.exe" -ArgumentList "/auto upgrade /dynamicupdate enable /copylogs $logDir /quiet /eula accept" -Wait
Suggested change
Start-Process -FilePath "$DVDDrive\setup.exe" -ArgumentList "/auto upgrade /dynamicupdate enable /copylogs $logDir /quiet /eula accept"
Start-Process -FilePath "$DVDDrive\setup.exe" -ArgumentList "/auto upgrade /dynamicupdate enable /copylogs $logDir /quiet /eula accept" -Wait

Copilot uses AI. Check for mistakes.
- If the adapter name is changed, check if the previous adapter is orphaned or ghosted.

```powershell
Get-PnpDevice -class net | ? Status -eq Unknown | Select FriendlyName,InstanceId
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] This PowerShell command has multiple style issues for documentation:

  1. The -class parameter should be -Class (proper casing)
  2. The ? alias should be Where-Object for clarity
  3. Select should be Select-Object

Consider updating to:

Get-PnpDevice -Class net | Where-Object Status -eq Unknown | Select-Object FriendlyName,InstanceId
Suggested change
Get-PnpDevice -class net | ? Status -eq Unknown | Select FriendlyName,InstanceId
Get-PnpDevice -Class net | Where-Object Status -eq Unknown | Select-Object FriendlyName,InstanceId

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants