-
Notifications
You must be signed in to change notification settings - Fork 427
Upgrade SDN infrastructure #3998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade SDN infrastructure #3998
Conversation
|
@ManikaDhiman : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 1ac6938: ✅ Validation status: passed
For more details, please refer to the build report. |
PRMerger Results
|
|
Can you review the proposed changes? If you approve the new content in this PR, the commits must be moved to the private repository for automated checks and publishing. After you move the commits, close this PR ( Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive documentation for upgrading Software Defined Networking (SDN) infrastructure managed by on-premises tools in Azure Local environments. The documentation provides step-by-step procedures for safely upgrading various SDN components and includes troubleshooting guidance for common issues.
Key Changes
- New how-to guide covering in-place OS upgrades for SDN infrastructure components including Hyper-V hosts, Network Controller VMs, Load Balancer Multiplexers, and Gateway VMs
- Detailed PowerShell-based workflows with code examples for each upgrade scenario
- Troubleshooting section addressing common upgrade issues like Service Fabric node health, DNS resolution, and configuration state failures
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 14 comments.
| File | Description |
|---|---|
| azure-local/manage/upgrade-sdn.md | New documentation file providing complete upgrade procedures for SDN infrastructure with prerequisite steps, component-specific upgrade workflows, and troubleshooting guidance |
| azure-local/TOC.yml | Adds table of contents entry for the new upgrade documentation, positioned logically after the existing "Update SDN infrastructure" entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # /dynamicupdate enables the download of updates during the upgrade process. | ||
| # added " /quiet" and " /EULA accept" to arguments for the setup.exe command, to suppress the GUI and accept the EULA. | ||
|
|
||
| Start-Process -FilePath "$DVDDrive\setup.exe" -ArgumentList "/auto upgrade /dynamicupdate enable /copylogs $logDir /quiet /eula accept" |
Copilot
AI
Nov 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command Start-Process is called without the -Wait parameter. This means the script will continue immediately without waiting for the upgrade to complete, which could cause issues with subsequent steps. Consider adding -Wait to ensure the upgrade finishes before proceeding:
Start-Process -FilePath "$DVDDrive\setup.exe" -ArgumentList "/auto upgrade /dynamicupdate enable /copylogs $logDir /quiet /eula accept" -Wait| Start-Process -FilePath "$DVDDrive\setup.exe" -ArgumentList "/auto upgrade /dynamicupdate enable /copylogs $logDir /quiet /eula accept" | |
| Start-Process -FilePath "$DVDDrive\setup.exe" -ArgumentList "/auto upgrade /dynamicupdate enable /copylogs $logDir /quiet /eula accept" -Wait |
| - If the adapter name is changed, check if the previous adapter is orphaned or ghosted. | ||
|
|
||
| ```powershell | ||
| Get-PnpDevice -class net | ? Status -eq Unknown | Select FriendlyName,InstanceId |
Copilot
AI
Nov 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] This PowerShell command has multiple style issues for documentation:
- The
-classparameter should be-Class(proper casing) - The
?alias should beWhere-Objectfor clarity Selectshould beSelect-Object
Consider updating to:
Get-PnpDevice -Class net | Where-Object Status -eq Unknown | Select-Object FriendlyName,InstanceId| Get-PnpDevice -class net | ? Status -eq Unknown | Select FriendlyName,InstanceId | |
| Get-PnpDevice -Class net | Where-Object Status -eq Unknown | Select-Object FriendlyName,InstanceId |
No description provided.