Make the TripPin.Feed type change more clear
#522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brandonstubbs : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 8eccc7d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
@brandonstubbs : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
JasonWHowell
added
the
needs-engineering-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed the step of updating the
connectorcode to change the schema parameter and it took a while to figure out why all my unit tests were coming back asnullexcept for theCheck that we have three entries in our nav tabletest. It might be better to explicitly show this step. LMKWYT