Fix 3 critical validation issues#2
Merged
Merged
Conversation
- Add CC_SIDECAR_NATS_TOKEN env var support and EnvironmentFile directive in systemd unit - Move parseTranscript and onComplete callback outside tracker mutex to prevent blocking during network I/O - Detect failed sessions (no assistant messages = exit code 1) and route to PublishFailed Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CC_SIDECAR_NATS_TOKENenv var override in both pre-config and post-config env blocks; addEnvironmentFile=-/etc/cc-sidecar/envto systemd unitparseTranscript()andonComplete()outsidetracker.mulock — collect ready paths under the lock, then process outside it to prevent blockingTouch()during NATS publish/KV lookupExitCode: 1) and route toPublishFailed()so Warren receives both completed and failed eventsTest plan
go build ./...passesgo test ./...passes (new exit code detection tests added)CC_SIDECAR_NATS_TOKENset via/etc/cc-sidecar/envand verify NATS authswarm.cc.session.completedis publishedswarm.cc.session.failedis published🤖 Generated with Claude Code