feat: metadata conventions + cargo fmt fix (spec 17)#44
Merged
Conversation
Fixes CI cargo fmt --check failures for files from trust scoring, entity layer, briefing roles, briefing scope, and legacy rule deprecation implementations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add conventions.rs with check_conventions() for well-known metadata keys (entity_type, aliases, parent_agent, task_id, source_url, content_type, language, expires_reason) and entity type constants. CLI: add --metadata and --check-conventions flags to node create. Python SDK: add EntityType constants, store_entity() on Cortex and MockCortex, 10 new tests. TypeScript SDK: add EntityType enum, StoreEntityOptions, storeEntity() on Cortex and MockCortex, 8 new tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo fmt, fixing the CIcargo fmt --checkfailurescortex-coremodule withcheck_conventions()validation, well-known metadata key constants (entity_type,aliases,parent_agent,task_id,source_url,content_type,language,expires_reason), and entity type constants — 13 unit tests--metadata(JSON) and--check-conventionsflags oncortex node createEntityTypeconstants,store_entity()onCortex+MockCortex— 10 new testsEntityTypeenum,StoreEntityOptions,storeEntity()onCortex+MockCortex— 8 new testsTest plan
cargo fmt --all -- --checkpasses (previously failing)cargo clippy --workspace -- -D warningscleancargo clippy --workspace --no-default-features -- -D warningscleancargo test --workspace --no-default-features— 527 tests passnpm test— 37/37 pass🤖 Generated with Claude Code