Skip to content

Add functions to measure which are changable in the modal #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 18, 2024
Merged

Add functions to measure which are changable in the modal #426

merged 3 commits into from
Dec 18, 2024

Conversation

laurensWe
Copy link
Member

@laurensWe laurensWe commented Dec 12, 2024 •
edited
Loading

Description

  • Add three functions to the measure modal
  • Set status to the second column in the modal
  • Update the measure pydantic schema
  • Update the system card with the functions when updated

Resolves #384

Checklist

Please check all the boxes that apply to this pull request using "x":

  • I have tested the changes locally and verified that they work as expected.
  • I have followed the project's coding conventions and style guidelines.
  • I have rebased my branch onto the latest commit of the main branch.
  • I have squashed or reorganized my commits into logical units.
  • I have read, understood and agree to the Developer Certificate of Origin, which this project utilizes.

@laurensWe laurensWe requested a review from a team as a code owner December 12, 2024 13:49
@laurensWe laurensWe linked an issue Dec 12, 2024 that may be closed by this pull request
Assign functions for handling a measure #384
Closed
5 tasks
@laurensWe laurensWe force-pushed the 384-assign-functions-for-handling-a-measure branch 3 times, most recently from 691dd68 to e0b0da9 Compare December 18, 2024 13:59
@laurensWe laurensWe force-pushed the 384-assign-functions-for-handling-a-measure branch from e0b0da9 to 8b0adcb Compare December 18, 2024 14:02
berrydenhartog
berrydenhartog approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@berrydenhartog berrydenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
56.8% Coverage on New Code (required ≥ 95%)

See analysis details on SonarQube Cloud

@laurensWe laurensWe enabled auto-merge December 18, 2024 14:11
@laurensWe laurensWe merged commit 12b2868 into main Dec 18, 2024
13 of 14 checks passed
@laurensWe laurensWe deleted the 384-assign-functions-for-handling-a-measure branch December 18, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berrydenhartog berrydenhartog berrydenhartog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assign functions for handling a measure
2 participants
@laurensWe @berrydenhartog