[Rosetta fix] Install git & revert rosetta -> mesh change#17209
Merged
[Rosetta fix] Install git & revert rosetta -> mesh change#17209
Conversation
Member
Author
|
!ci-build-me |
Member
Author
|
!ci-nightly-me |
e5560ef to
a7b755f
Compare
Member
Author
|
!ci-nightly-me |
Member
Author
|
!ci-build-me |
Member
Author
|
Nightly on previous commit (before rebase, just to explore alternative fix) https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/3649#0196da4d-18cd-4446-9791-4d9fb8b844e7 |
Member
Author
This was referenced May 19, 2025
SanabriaRusso
approved these changes
May 19, 2025
georgeee
approved these changes
May 19, 2025
Member
|
!approved-for-mainnet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original issue was:
Which was fixed by changing lib name from rosetta-sdk-go -> mesh-sdk-go. This unblocked rosetta docker build but caused another problem which is visible on 3 mainline branches at integration tests:
(https://buildkite.com/o-1-labs-2/mina-mainline-branches-nightlies/builds/183#0196d740-fd12-40d1-9090-75205e843a5f)
Above fix is unfortunately partial since we are using our fork (minaprotocol/rosetta-sdk-go) instead of original mesh library, which was replacing orginal rosetta sdk while building docker. See coinbase/mesh-sdk-go#464.
After we renamed rosetta-sdk -> mesh-sdk we broke replacement operation since mesh-cli still depends on rosetta-sdk-go not mesh-sdk-go. :
entry after running go mod graph:
This command did not error out but it failed to replace module. As a result we have issue with signingPayload since it uses orginal mesh version which is not compatible with our rosetta impl.
Looks like the correct fix is just to install git, to allow go download and initialize rosetta-sdk-go lib