Skip to content

[Rosetta fix] Install git & revert rosetta -> mesh change#17209

Merged
dkijania merged 2 commits intomasterfrom
dkijania/once_again_fix_rosetta
May 19, 2025
Merged

[Rosetta fix] Install git & revert rosetta -> mesh change#17209
dkijania merged 2 commits intomasterfrom
dkijania/once_again_fix_rosetta

Conversation

@dkijania
Copy link
Copy Markdown
Member

@dkijania dkijania commented May 16, 2025

Original issue was:

github.com/coinbase/rosetta-sdk-go/[email protected]: git init --bare in /root/go/pkg/mod/cache/vcs/b533490f0e0edb9a52f10692f73836419bd8db7ac5bda88f3c45fc77ca71fdd7: exec: "git": executable file not found in $PATH

Which was fixed by changing lib name from rosetta-sdk-go -> mesh-sdk-go. This unblocked rosetta docker build but caused another problem which is visible on 3 mainline branches at integration tests:

Command Failed: unable to create transaction: unable to sign payloads: unable to to sign payload: failed to parse signing payload: payment not found in signingPayload
🚨 Error: The command exited with status 1

(https://buildkite.com/o-1-labs-2/mina-mainline-branches-nightlies/builds/183#0196d740-fd12-40d1-9090-75205e843a5f)

Above fix is unfortunately partial since we are using our fork (minaprotocol/rosetta-sdk-go) instead of original mesh library, which was replacing orginal rosetta sdk while building docker. See coinbase/mesh-sdk-go#464.

After we renamed rosetta-sdk -> mesh-sdk we broke replacement operation since mesh-cli still depends on rosetta-sdk-go not mesh-sdk-go. :

entry after running go mod graph:

...
github.com/coinbase/rosetta-cli github.com/coinbase/[email protected]
....

This command did not error out but it failed to replace module. As a result we have issue with signingPayload since it uses orginal mesh version which is not compatible with our rosetta impl.

Looks like the correct fix is just to install git, to allow go download and initialize rosetta-sdk-go lib

@dkijania dkijania requested a review from a team as a code owner May 16, 2025 17:31
@dkijania
Copy link
Copy Markdown
Member Author

!ci-build-me

@dkijania
Copy link
Copy Markdown
Member Author

!ci-nightly-me

@dkijania dkijania force-pushed the dkijania/once_again_fix_rosetta branch from e5560ef to a7b755f Compare May 16, 2025 19:36
@dkijania
Copy link
Copy Markdown
Member Author

!ci-nightly-me

@dkijania
Copy link
Copy Markdown
Member Author

!ci-build-me

@dkijania
Copy link
Copy Markdown
Member Author

Nightly on previous commit (before rebase, just to explore alternative fix) https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/3649#0196da4d-18cd-4446-9791-4d9fb8b844e7

@dkijania dkijania changed the title Merge pull request #16883 from MinaProtocol/dkijania/remove_logs [Rosetta fix] Install git & revert rosetta -> mesh change May 16, 2025
@coveralls
Copy link
Copy Markdown

coveralls commented May 16, 2025

Coverage Status

coverage: 60.786% (+24.9%) from 35.868%
when pulling a7b755f on dkijania/once_again_fix_rosetta
into 66746e2 on master.

@dkijania dkijania self-assigned this May 16, 2025
@dkijania
Copy link
Copy Markdown
Member Author

@georgeee
Copy link
Copy Markdown
Member

!approved-for-mainnet

@dkijania dkijania merged commit 0a2ab50 into master May 19, 2025
19 checks passed
@dkijania dkijania deleted the dkijania/once_again_fix_rosetta branch May 19, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants