Skip to content

Reduce memory leak by 20-25% in looping proofs #17443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Fizzixnerd
Copy link

Explain your changes:

  • Updates proof-systems submodule to 9f416dd2d7 to include memory-safe
    Lagrange commitment functions that prevent memory leaks during proof
    generation

Explain how you tested your changes:

  • Verified the new functions are available in the bindings
  • Ran o1js test suite to ensure compatibility
  • Tested memory usage patterns with recursive proof generation
  • See Memory Leak 20-25% fix o1-labs/o1js#2262 for details

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • [N/A] Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • [N/A] Serialized types are in stable-versioned modules
  • [N/A] Does this close issues? List them

@Fizzixnerd Fizzixnerd requested a review from a team as a code owner June 26, 2025 19:37
…functions

Includes memory leak fixes for Lagrange commitment operations that prevent
memory accumulation during proof generation processes.
@Fizzixnerd Fizzixnerd force-pushed the fizzixnerd/o1js-memory-leak-fix branch from 5df4bb3 to 1a3a9d0 Compare June 26, 2025 19:39
@Fizzixnerd Fizzixnerd self-assigned this Jun 26, 2025
@Fizzixnerd Fizzixnerd marked this pull request as draft June 27, 2025 07:08
@Fizzixnerd Fizzixnerd closed this Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant