App state32 #17462
Open
App state32 #17462
+5,866
−2,156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
|
!ci-build-me |
glyh
reviewed
Jul 2, 2025
| @@ -70,7 +70,7 @@ module Account_update_under_construction = struct | |||
| type t = { app_state : Field.t option Zkapp_state.V.t } | |||
|
|
|||
| let create () = | |||
| { app_state = [ None; None; None; None; None; None; None; None ] } | |||
| { app_state = Mina_base.Zkapp_state.V.init ~f:(fun _ -> None) } | |||
There was a problem hiding this comment.
❯rg -t ml 'fun _ ->' | wc -l
330
rg -t ml 'const ' | wc -l
224It looks like we use a mix of the two 😢
I don't feel strongly, I'm happy to use const here.
There was a problem hiding this comment.
Well, they are slightly different in that const a always evaluate eagerly, while fun _ -> a does not.
But for sure compiler may optimize them into the samething
glyh
reviewed
Jul 2, 2025
| { app_state = [ Keep; Keep; Keep; Keep; Keep; Keep; Keep; Keep ] | ||
| { app_state = | ||
| Mina_base.Zkapp_state.V.init ~f:(fun _ -> | ||
| Zkapp_basic.Set_or_keep.Keep ) |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
7 tasks
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
@Geometer1729 can you rebase onto/merge newest develop ? |
|
!ci-docker-me |
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes:
Explain how you tested your changes:
No additional tests