docs: make HELM ecosystem map authoritative - #34
Conversation
|
Strix is installed on this repository, but we couldn't run this PR security review because this workspace's trial has ended. Add a card to resume code reviews here. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87324c7598
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| def write_outputs(markdown) | ||
| [TEAM_DOC_PATH, ROOT_DOC_PATH].each do |path| | ||
| [ROOT_DOC_PATH, TEAM_DOC_PATH, HANDBOOK_DOC_PATH].each do |path| |
There was a problem hiding this comment.
Whitelist the handbook map before writing it
In a full workspace after this generated output is committed to docs-engineering-handbook, the headless-UI reference gate will scan that active repo but still only allows docs/onboarding/helm-ecosystem-directory-map.md in docs_for_team (scripts/check-headless-ui-references.rb lines 57-67). The generated markdown always includes the manifest deleted repositories (app-docs-platform and platform-design-system) from lines 306-307, and both names are banned by that gate, so make lint/the org docs-truth scan will fail for the new handbook copy unless this path is allowed or excluded.
Useful? React with 👍 / 👎.
|
Closing without merge as superseded by #39. PR #39 replaces the workstation-dependent generator with deterministic manifest/policy topology and explicitly excludes transient local directories. Its paired generated outputs are tracked in docs#86 and docs_for_team#98. The old branch is preserved; no merge or authority claim is made here. |
|
Cleanup follow-up: after closure, the remote ref was re-read at exact audited head 87324c7 and its attached worktree was confirmed clean. The exact remote ref, clean worktree, and matching local branch have now been removed. The closed PR ref retains recovery lineage. |
Summary
Validation
ruby -c scripts/generate-helm-ecosystem-map.rbMINDBURN_WORKSPACE_ROOT=<full-overlay> REQUIRE_WORKSPACE_CONTEXT=1 make lintCoordinated with Mindburn-Labs/docs#74.