fix(authority): verify workflow semantics structurally - #38
Open
mindburnlabs wants to merge 3 commits into
Open
Conversation
This was referenced Jul 16, 2026
Base automatically changed from
codex/autonomous-release-gen2-bootstrap
to
codex/autonomous-release-controller
July 20, 2026 20:18
Base automatically changed from
codex/autonomous-release-controller
to
codex/autonomous-release-recovery
July 20, 2026 20:19
Workspace sync 2026-07-20 backup before worktree cleanup. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mindburnlabs
marked this pull request as ready for review
July 20, 2026 22:22
|
Strix is installed on this repository, but we couldn't run this PR security review because this workspace's trial has ended. Add a card to resume code reviews here. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
peycheff-com
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: P0 hold
This draft is not a merge candidate. An independent adversarial review found that its initial structural verifier validated only selected prepare and permit steps while allowing mutations of execution context and the privileged machine-approval lane.
Required remediation
The successor must use a parent-owned, complete allowlist for the authority workflow: exact top-level execution controls, known job graph, ordered authority-sensitive steps, checkout origins/pins/paths, action inputs, environments, command identity, artifact paths, and the full approval-App token chain. Extra jobs, triggers, steps, defaults, shell/working-directory/if/continue-on-error changes, alternate checkout/execution forms, and approval-token consumers must fail closed.
Narrow proof retained
The current head does correctly reject malformed YAML, duplicate keys, aliases, merge keys, and several direct checkout/prepare mutations. That narrow proof is insufficient for authority promotion and does not authorize merge, deployment, ruleset activation, or human-gate removal.
Validation state
Current exact head passed local-validation and source-owned make lint plus 93 tests, but those checks predate the P0 adversarial mutations. The draft remains held pending the complete semantic allowlist, expanded negative tests, a fresh independent review, and live control-plane canary evidence.