Skip to content

feat: ship twelve runnable framework helpers#17

Open
mindburnlabs wants to merge 4 commits into
mainfrom
codex/helm-183-helper-examples
Open

feat: ship twelve runnable framework helpers#17
mindburnlabs wants to merge 4 commits into
mainfrom
codex/helm-183-helper-examples

Conversation

@mindburnlabs

Copy link
Copy Markdown
Contributor

Summary

  • package all twelve framework normalizers as runnable TypeScript and Python examples
  • exercise their /api/v1/evaluate request contract through in-process transports and prove denied unknown-tool dispatch stays at zero
  • run source and packed npm/wheel consumers in CI on Python 3.9 and 3.12
  • pin helper release tooling and use npm ci for repeatable dependency installs

Truth boundary

These are deterministic simulated preflight/deny contract examples. They do not call a live Kernel or provider, dispatch an external effect, or create an EvidencePack; they do not close the CompanyArtifactGraph → GeneratedSpec → Kernel → EvidencePack objective.

Validation

  • make validate
  • make package
  • actionlint .github/workflows/helm-boundary-check.yml
  • docs truth local check
  • independent review (no P0/P1 findings)

@strix-security

Copy link
Copy Markdown

Strix is installed on this repository, but we couldn't run this PR security review because this workspace's trial has ended. Add a card to resume code reviews here.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ca7dd52d96

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

trap 'rm -rf "$consumer_dir"' EXIT
python -m venv "$consumer_dir/venv"
"$consumer_dir/venv/bin/python" -m pip install --no-index --no-deps "$PWD/$wheel"
"$consumer_dir/venv/bin/python" -m helm_tool_wrapper.examples.framework_helpers

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Run the wheel smoke test outside the source tree

In the Python half of this package-assembly check, the venv invocation still runs from packages/python/helm_tool_wrapper, so Python puts the checkout on sys.path before the venv's site-packages. If the wheel is missing core files such as helm_tool_wrapper/boundary.py or otherwise contains stale installed code, python -m helm_tool_wrapper.examples.framework_helpers can pass by importing the source tree instead of the installed wheel; the JS half avoids this by changing into the temp consumer directory. Change to the temp consumer (or another directory outside the source tree) before running the module so this validates the wheel artifact.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant