chore(public-surface): remove Titan reference pack and Polymarket connector - #795
Open
mindburnlabs wants to merge 3 commits into
Open
chore(public-surface): remove Titan reference pack and Polymarket connector#795mindburnlabs wants to merge 3 commits into
mindburnlabs wants to merge 3 commits into
Conversation
…nector helm-ai-kernel is the public, Apache-2.0 execution-firewall repo. It shipped `reference_packs/titan_hedge_fund.v1.json`, whose `prog-polymarket-live` program is labelled "Polymarket Live Trading" with `status: active`, plus `core/pkg/connectors/polymarket/` — the only named trading-venue connector in the repo. Titan is a paused internal program under a no-public-claims hold, so neither belongs on a public surface. - Delete `reference_packs/titan_hedge_fund.v1.json`. Top-level policy reference packs go from 7 to 6. - Delete the whole `core/pkg/connectors/polymarket/` package. Nothing in the repo imported it — `git grep connectors/polymarket` outside the package itself returned no hits — so no shim was needed. - Drop the "(e.g., Polymarket)" aside from the CFTC regwatch adapter doc comment. CFTC jurisdiction over prediction markets is the point; the venue name is not. No behaviour change. - Rename the CFTC compliance test fixture id `polymarket-001` to `event-mkt-001`, matching the neighbouring `swap-mkt-001` idiom. Compliance functionality is untouched. `docs/security/kernel-security-remediation-ledger.md` row `helm-ai-kernel-FILE-0492-A` still reads "Polymarket order amount validation". That is a historical record of a past finding, deliberately left intact. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Strix is installed on this repository, but we couldn't run this PR security review because this workspace's trial has ended. Add a card to resume code reviews here. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The public-surface argument reaches an internal-program reference pack and a named-venue connector. It does not reach a Go doc comment citing a public prediction market as an example of CFTC jurisdiction, nor a test fixture id. Both edits were behaviour-neutral noise; the diff is now deletions only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes an internal-program reference pack and a named-venue connector from the public surface: 6 files, deletions only (−1376), no behaviour change to anything that remains.
Reference packs go 7 → 6. Nothing in the repository asserts a pack count, so no in-repo claim needs updating; the public site's count is handled separately in app-mindburn-web.
Scope discipline
Deletions only. Two adjacent edits to compliance files were reverted from an earlier revision: a fixture-id rename and a doc-comment trim in the CFTC adapter are behaviour-neutral and the public-surface argument does not reach a Go doc comment, so they do not belong in this change.
What this does not do
Deleting from HEAD does not remove content from a public repository. Both artifacts remain retrievable from git history at any commit that contained them, permanently and by anyone. If that is unacceptable, this PR is necessary but not sufficient and a history-rewrite decision is required from the public-claims owner; it is deliberately not made here.
This body deliberately does not restate what the removed artifacts contained. PR bodies are indexed, and an earlier revision of this description reproduced that material on the public surface; describing the shape of the change is sufficient to review it.
Gates
29/29 checks green.
make test,make verify-fixtures,make verify-boundary(1103 entries, no drift),make docs-coverage,make docs-truthall pass on the branch.