4.2.1: more obstructed spawn fixes #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all modifications to the random call, formatting
I should change this injector, but I don't trust that first BlockPos local to stay around
8 1.21 subversions already??? where did the time go
tildejustin
merged commit 1ca1f7e
into
Minecraft-Java-Edition-Speedrunning:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this needs a lot of testing, and the person who requested the feature doesn't have the seeds, so that's cool!
I was not given some crucial information, which is that you also need a grass block under the obstructed spawn. I fixed this, it's not a parity concern but it would silently fail to use the set spawn instead of giving an error message. Additionally, since we're at the end of the loop p * n gets added to o, so that needs to be reversed to actually set the spawn we want. Also not a parity concern but makes 4.2.0 not particularly useful for runners since it's still essentially random to what spawn you get vs what you put in, just deterministic randomness.
1.18+ has different spawning criteria but I think the mixins should still work, I tested 1.21.6 pretty well on the new ssg seed and I think it's right. I'm more scared of crashes than the code being wrong but both are always a possibility :).
took the opportunity to clean up some metadata, the icon wasn't a square or a power of 2 resolution, there was no links, and I set setspawn-common as a library and a child mod for modmenu b/c why not. I should do the same for state output at some point.
I think I'm going to go insane if I have to look at setspawn code again for a while so if this doesn't work, idk, I give up.