PRODENG-2780 mke output handler #557
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-nesbitt
force-pushed
the
PRODENG-2780-mke-output-handler
branch
4 times, most recently
from
2badd0b to
c46dd6a
Compare
james-nesbitt
force-pushed
the
PRODENG-2780-mke-output-handler
branch
7 times, most recently
from
dfaa3f1 to
f95c00c
Compare
|
This is ready for testing. |
james-nesbitt
force-pushed
the
PRODENG-2780-mke-output-handler
branch
from
f95c00c to
e856199
Compare
|
I think that we may hold off on this effort for the current release. |
james-nesbitt
force-pushed
the
PRODENG-2780-mke-output-handler
branch
5 times, most recently
from
e650d8c to
2ee2c71
Compare
- new MKE function for running the bootstrapper on a cluster - new buffer function that can be used to capture rig Exec command output for scanning without early EOFs - some buffer helpers that can relay rig Exec output if it outputs logrus Signed-off-by: James Nesbitt <[email protected]> PRODENG-2780 MSR cmdbuffer usage - MKE style cmdbuffer usage - migrating the install and upgrade and pull images phases to use the new cmdbuffer based bootstrap functions Signed-off-by: James Nesbitt <[email protected]>
james-nesbitt
force-pushed
the
PRODENG-2780-mke-output-handler
branch
from
2ee2c71 to
15df06e
Compare
|
the k0s team is not interested in the cmdbuffer approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor how we handle the output from the MKE and MSR docker run bootstrapping. Primarily focused on better consuming log messages from the bootstrappers natively into launchpad log messages (proper log level handling, better message handling,) but also de-duping the docker runs themselves
The command buffer may actually be something that the k0sproject/rig project is interested in.