Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change root password from emtpy to something reasonable #77

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

mistyron
Copy link
Contributor

Set a default user password

@mistyron mistyron changed the title Change user password from emtpy to something reasonable Change root password from emtpy to something reasonable Jul 30, 2024
Build/start.sh Outdated
# Set default root password
#cat <<EOT >> ${LOCALCONF}
echo "inherit extrausers" >> ${LOCALCONF}
echo "EXTRA_USERS_PARAMS = \"usermod -P M15+y50M8ackd00r root\"" >> ${LOCALCONF}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the initial password should be simple, like every live media or router. It would be up to the user to change it when they first log in.

I suggest usermod -P root root or usermod -P pass root instead.

Copy link
Contributor Author

@mistyron mistyron Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of providing us a backdoor for YVR05 - I realize that it should not be merged into the public repo then - we can do something like:
usermod -P root root in the public repo if we want, yes

Build/start.sh Outdated
@@ -52,6 +52,12 @@ MACHINE_FEATURES_append = " docker"
DISTRO_FEATURES_append = " virtualization"
EOT

# Set default root password
#cat <<EOT >> ${LOCALCONF}
echo "inherit extrausers" >> ${LOCALCONF}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be echo "INHERIT += \"extrausers\" >> ${LOCALCONF}

Copy link
Contributor Author

@mistyron mistyron Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified it to:

INHERIT += "extrausers"
EXTRA_USERS_PARAMS = "usermod -P root root"

mistyron added 2 commits July 31, 2024 14:52
fixed INHERIT line
setting default password to "root"
@mistyron mistyron requested a review from matinlotfali August 5, 2024 08:55
Copy link
Contributor

@matinlotfali matinlotfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistyron mistyron marked this pull request as ready for review August 6, 2024 10:33
@mistyron mistyron merged commit 4f0b4b9 into develop Aug 6, 2024
2 checks passed
@mistyron mistyron deleted the root-user-pwd branch August 6, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants