-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future availability by vehicle #726
base: master
Are you sure you want to change the base?
Conversation
Thanks @richfab. |
Hi @matt-wirtz, As suggested, I added I renamed I made the field Do you or anyone else see any other things that should be changed in the proposal? If not, I propose to open a vote in 7 days. Thank you very much for your contributions and patience 🙏 |
Couldn’t we handle that case with |
Good points @futuretap. I made Does anyone see anything else that should be changed in the proposal? If not, a vote will be opened in 7 days. Thanks! |
Thank you to everyone who contributed to this proposal in #616, #722 and #726 🙏 I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on Friday, February 28. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Governance on the spec change process can be found here. |
+1 from Hacon (consumer) are going to implement this |
raumobil votes for the proposal. We are going to implement this as a consumer. |
+1 from Where To? / FutureTap (consumer). We plan to implement this. |
Please feel free to mention this vote to operators who wish to produce future vehicle availability data. |
Voting on this PR closes in 2 calendar days. I encourage those who are in contact with data producers who would like to publish Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal. Thanks! |
@richfab thank you for reaching out! |
Having reviewed the spec, I am not against it perse (apart from the privacy requirement, see below), but business who work with vehicles types instead of specific vehicles cannot use this approach in any way. It make me think whether we should split booking information from vehicle availability. The latter seems to be served pretty well by this proposal, but the former is not for vehicle-type-only based businesses. Effectively, our operators won't be able to provide a feed based on this spec. In short because they do not maintain booking information for specific vehicles, only for vehicle types. [EDIT: I see now this is addressed by a separate PR #722] This is basically why I created TOMP feature request Future asset booking spot capacity. I guess we'd need to follow up on the 'calendar' feature anyway (see also my comment here: #616 (comment) I haven't wrapped my head around what it would return in detail but something like this: Request:
Response:
Questions:
Depending on different factors, the information will almost certainly be inaccurate. If the granularity of booking periods for individual bookings is more fine grained than the timeslot size, this will lead to small inaccuracies. However, I doubt the inaccuracy will be relevant for most common use cases if we manage to choose the right timeslot sizes. I know from experience that calculating the above can be quite tricky, especially if bookings are vehicle type based instead of vehicle id based. However, this offers great flexibility to our customers. One last remark that I have about the spec is regarding the privacy issue. Is a similar requirement already addressed in other files? Imho I find this requirement a bit of overkill. Afaik we do not require car operators to switch their cars' license plates after each rental. Nor do we require bike operators to replace physical QR codes on their bikes. If a malicious force wants to misuse vehicle identity they will find a way anyhow. I am afraid this unnecessarily complicates the spec and corresponding implementations. But then again, I do not know if similar requirements already exist in current specs and whether this is already legally enforced. But if you ask me I would remove it. |
Ah, I see this is already addressed in #722. Apologies. I will place further comments in the corresponding thread. |
@eborremans Regarding the privacy issue, please see here: |
@richfab I am talking to operators, I already hoped to see one of them here. |
Regarding systems that work with vehicle types instead of specific vehicles, mentioned by @eborremans:
EDIT: If availability is needed by vehicle type, this should probably be in a different endpoint to avoid mixing concepts (for example as suggested in #722). |
@richfab regarding making |
Regarding the both concepts "vehicle availability" and "vehicle type availability". |
Dear all, I would like to vote for the proposal: We as VMZ would like to use the new values as an information supplier for the sharing vehicles in our mobility data platforms (meta platforms) and pass them on accordingly in potential projects |
@matt-wirtz @richfab I agree, 2 endpoints would be fine and avoid confusion. |
+1 I vote for the proposal hoping that we also get a similar endpoint for vehicle type availability. |
@eborremans Would you like to provide the name of the organization you are voting for? |
This vote has now closed, and it passes! Votes in favor:
There were no votes against. This change will be part of the next MINOR Release Candidate, planned in May 2025, as per the version release cycle in the governance. Producers and consumers can still start implementing it and become First Adopters. Thank you all for your involvement in the GBFS spec 🙏 |
What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.
Following the discussion in #616 and #722
Operators want to be able to describe the future availability of their services, for example to display it in trip planners. This is particularly useful for systems that allow vehicles to be booked in advance (e.g. carsharing, cargo bike share, etc).
What is the proposal?
Add a new OPTIONAL endpoint
vehicle_availability.json
which describes the future availability of each vehicle.Is this a breaking change?
Which files are affected by this change?
Proposal to add a new OPTIONAL endpoint:
vehicle_availability.json
Example