Feat[main]: add a workaround to ignore program link errors#29
Open
whitebelyash wants to merge 1 commit into
Open
Feat[main]: add a workaround to ignore program link errors#29whitebelyash wants to merge 1 commit into
whitebelyash wants to merge 1 commit into
Conversation
Minecraft 26.3-s2 has new shaders around block transparency, however, these shaders aren't handled well by most GLES drivers. Allow an optional workaround to force successful program link status to make the game not blow up. From my testing on ANGLE (one of the problematic drivers) the only thing breaking is transparent blocks - it's quite hard to call them broken though, just a bit weird. The error itself is seemingly unrelated to our shader transpiler and can be reproduced on other GLES wrappers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes, this MIGHT cause an undefined behavior. But I still prefer having this in LTW for debugging purposes.
Minecraft 26.3-s2 has new shaders around block transparency, however, these shaders aren't handled well by most GLES drivers. Allow an optional workaround to force successful program link status to make the game not blow up.
From my testing on ANGLE (one of the problematic drivers) the only thing breaking is transparent blocks - it's quite hard to call them broken though, just a bit weird.
The error itself is seemingly unrelated to our shader transpiler and can be reproduced on other GLES wrappers.